Refactor generate-artifacts-executor.js: decouple schema and native files generation #41555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
dmytrorykun
force-pushed
the
export-D51204077
branch
from
8089a13 to
b4dfba9
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: Pull Request resolved: facebook#41555 This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Differential Revision: D51204077 fbshipit-source-id: 771a931ef1e248c97955b64a14c1fb2d169d920a
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
dmytrorykun
force-pushed
the
export-D51204077
branch
from
b4dfba9 to
3955399
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: Pull Request resolved: facebook#41555 This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Differential Revision: D51204077 fbshipit-source-id: 55d8256f5edec4973363dbc15e41fb01e8076b80
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Differential Revision: D51204077
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Differential Revision: D51204077
dmytrorykun
force-pushed
the
export-D51204077
branch
from
3955399 to
d4ab0ab
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…iles generation (facebook#41555) Summary: Pull Request resolved: facebook#41555 This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Differential Revision: https://internalfb.com/D51204077 fbshipit-source-id: edb054d7974c6c1be325bb40ad72b8068553de77
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
force-pushed
the
export-D51204077
branch
from
d4ab0ab to
89b12fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
Base commit: 3ecf1bc |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
force-pushed
the
export-D51204077
branch
from
89b12fc to
1941e5a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
force-pushed
the
export-D51204077
branch
from
1941e5a to
4025a82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2023
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2023
…iles generation (facebook#41555) Summary: Pull Request resolved: facebook#41555 This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077 fbshipit-source-id: 9ec5698d81771023c6a3853800e7d49f41115e21
dmytrorykun
force-pushed
the
export-D51204077
branch
from
4025a82 to
803272e
Compare
…iles generation (facebook#41555) Summary: This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077
dmytrorykun
force-pushed
the
export-D51204077
branch
from
803272e to
2f7d57e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51204077 |
|
This pull request has been merged in 980fb0c. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…iles generation (facebook#41555) Summary: Pull Request resolved: facebook#41555 This diff splits `generateNativeCodegenFiles` into two simpler steps: `generateSchemaInfos` and `generateCode`. `SchemaInfo` is a (library, schema) pair, it is convenient for further transformations. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51204077 fbshipit-source-id: 8a1f585a79a2a0241b544a8a131b59250d803e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff splits
generateNativeCodegenFilesinto two simpler steps:generateSchemaInfosandgenerateCode.SchemaInfois a (library, schema) pair, it is convenient for further transformations.Changelog: [Internal]
Differential Revision: D51204077