Fix ReactInstanceManager for getting rid of getJSIModule() #41495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51338036 |
Base commit: 803c5bb |
arushikesarwani94
force-pushed
the
export-D51338036
branch
from
f27d2a5 to
d5ffbcd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51338036 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Nov 16, 2023
…acebook#41495) Summary: Fix ReactInstanceManager for adding the callsite of `getJSIModule()` as an alternate path to new way of Fabric initialization in order to make Catalyst and RN-Tester work with the changes for Fabric initialization Reviewed By: javache Differential Revision: D51338036
arushikesarwani94
force-pushed
the
export-D51338036
branch
from
d5ffbcd to
3bf5b50
Compare
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Nov 20, 2023
…acebook#41495) Summary: Fix ReactInstanceManager for adding the callsite of `getJSIModule()` as an alternate path to new way of Fabric initialization in order to make Catalyst and RN-Tester work with the changes for Fabric initialization Reviewed By: javache Differential Revision: D51338036
|
This pull request was exported from Phabricator. Differential Revision: D51338036 |
…acebook#41495) Summary: Fix ReactInstanceManager for adding the callsite of `getJSIModule()` as an alternate path to new way of Fabric initialization in order to make Catalyst and RN-Tester work with the changes for Fabric initialization Reviewed By: javache Differential Revision: D51338036
arushikesarwani94
force-pushed
the
export-D51338036
branch
from
3bf5b50 to
93159c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51338036 |
|
This pull request has been merged in e832378. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41495) Summary: Pull Request resolved: facebook#41495 Fix ReactInstanceManager for adding the callsite of `getJSIModule()` as an alternate path to new way of Fabric initialization in order to make Catalyst and RN-Tester work with the changes for Fabric initialization Reviewed By: javache Differential Revision: D51338036 fbshipit-source-id: 49badac52f1032f1032a989b76dd422e3cf7582f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix ReactInstanceManager for getting rid of
getJSIModule()in order to make Catalyst and RN-Tester work with the changes for Fabric initializationDifferential Revision: D51338036