Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce RCTFoundation #41418

Closed
wants to merge 2 commits into from
Closed

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Nov 11, 2023

Summary:
Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 11, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 11, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 11, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 11, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@philIip philIip force-pushed the export-D51170983 branch 2 times, most recently from b874031 to cf54e34 Compare November 14, 2023 21:05
philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 16, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 16, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 17, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 17, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

Summary:

Changelog: [iOS][something]

Creating a new top level directory for Apple platform specific code.

Reviewed By: christophpurrer

Differential Revision: D51170984
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 19, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
philIip added a commit to philIip/react-native that referenced this pull request Nov 19, 2023
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51170983

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e9ecc65.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41418

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983

fbshipit-source-id: 8bc0a193b486f5a0653ad58d92a034cacede2d61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants