Remove yoga::Style::BitfieldRef #41393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 9, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Differential Revision: D51155925 fbshipit-source-id: 55c583b5f74f7406144bf3ed2ed328ba2ef298e2
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 9, 2023
Summary: Pull Request resolved: facebook#41393 X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Differential Revision: D51155925 fbshipit-source-id: 43679ff776ec701a1d11c5afe9f5c5d3c048f9b5
NickGerleman
force-pushed
the
export-D51155925
branch
from
5c6d935 to
e1109ac
Compare
Base commit: dc36be3 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Differential Revision: D51155925 fbshipit-source-id: a6f66163de61621f33b82411cbefecbcbbad7592
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: Pull Request resolved: facebook#41393 X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Differential Revision: D51155925 fbshipit-source-id: 3311be4d2592425a3703e213de99ec41ead2737d
NickGerleman
force-pushed
the
export-D51155925
branch
from
e1109ac to
983beee
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 21, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: bfda010d72a6801ede6f341a7b53a542e4934a4f
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 22, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: c4ee1c0b4c9f072c7ac79df6aae22f4c8527766d
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: 691d4683391e2d1c13306efbd1a09e1d79f4a5cc
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: 86f4b54fd7c4736628b9be0595710db9678216fe
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 25, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: facebook#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: a7e01cc2b381528296a832c1ff669dc3830fbe1d
NickGerleman
force-pushed
the
export-D51155925
branch
from
983beee to
b6de699
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
force-pushed
the
export-D51155925
branch
from
b6de699 to
02a2ccc
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 26, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
force-pushed
the
export-D51155925
branch
from
bb9d7bd to
6a2d306
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
force-pushed
the
export-D51155925
branch
from
6a2d306 to
858c8dc
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
force-pushed
the
export-D51155925
branch
from
858c8dc to
f5c6435
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
Summary: X-link: facebook/yoga#1462 Moves the last usages of `yoga::Style::Ref` to setters. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51154501
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
NickGerleman
force-pushed
the
export-D51155925
branch
from
f5c6435 to
8608c2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51155925 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/react-native#41393 X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: 2921c87d95ad36495b7013e592d5169015321545
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/react-native#41393 Pull Request resolved: #1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: 2921c87d95ad36495b7013e592d5169015321545
|
This pull request has been merged in 495fee4. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41393 X-link: facebook/yoga#1459 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925 fbshipit-source-id: 2921c87d95ad36495b7013e592d5169015321545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removes the last of the non setter-style style setters.
Differential Revision: D51155925