Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createAnimatedStyle when providing undefined transform style #41176

Closed
wants to merge 3 commits into from
+8 −1
Closed

Fix createAnimatedStyle when providing undefined transform style #41176

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9af3776
fix createAnimatedStyle when providing undefined transform style
gabrieldonadel Oct 24, 2023
580ff38
Add transform undefined example to RNTester
gabrieldonadel Oct 24, 2023
80b4ebf
Update packages/react-native/Libraries/Animated/nodes/AnimatedStyle.js
gabrieldonadel Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/Libraries/Animated/nodes/AnimatedStyle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ function createAnimatedStyle(
const animatedStyles: any = {};
for (const key in style) {
const value = style[key];
if (!value) {
continue;
}

if (key === 'transform') {
gabrieldonadel marked this conversation as resolved.
Show resolved Hide resolved
animatedStyles[key] =
ReactNativeFeatureFlags.shouldUseAnimatedObjectForTransform()
Expand Down
7 changes: 7 additions & 0 deletions packages/rn-tester/js/examples/Animated/TransformStylesExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ function AnimatedTransformStyleExample(): React.Node {
property => properties[property].selected,
)}
/>
<View style={styles.section}>
<Text>{'Should not crash when transform style key is undefined'}</Text>
<Animated.View style={[styles.animatedView, {transform: undefined}]} />
</View>
</View>
);
}
Expand All @@ -149,6 +153,9 @@ const styles = StyleSheet.create({
marginBottom: 6,
borderBottomWidth: 1,
},
section: {
marginTop: 20,
},
});

export default ({
Expand Down