introduce logic for shared native module queue #41042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
philIip
force-pushed
the
export-D50398635
branch
from
95eb1de to
b673ee8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
Base commit: 28d7ade |
philIip
force-pushed
the
export-D50398635
branch
from
b673ee8 to
c0b1b16
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 18, 2023
Summary: Changelog: [Internal] currently, each native module creates a new module queue if `methodQueue` is not overridden in the native module. we want to see if we can use a single execution queue for a few reasons: - parity with android's queue model - performance: creating so many queues... for what? the overhead of this feels like it exceeds any potential benefit - set us up to remove the assocs from the module to the method queue, which will allow us to deprecate `synthesize methodQueue` and `-(dispatch_queue_t)moduleQueue` API. in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue. Differential Revision: D50398635
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 20, 2023
Summary: Changelog: [Internal] currently, each native module creates a new module queue if `methodQueue` is not overridden in the native module. we want to see if we can use a single execution queue for a few reasons: - parity with android's queue model - performance: creating so many queues... for what? the overhead of this feels like it exceeds any potential benefit - set us up to remove the assocs from the module to the method queue, which will allow us to deprecate `synthesize methodQueue` and `-(dispatch_queue_t)moduleQueue` API. in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue. Reviewed By: cipolleschi Differential Revision: D50398635
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 20, 2023
Summary: Changelog: [Internal] currently, each native module creates a new module queue if `methodQueue` is not overridden in the native module. we want to see if we can use a single execution queue for a few reasons: - parity with android's queue model - performance: creating so many queues... for what? the overhead of this feels like it exceeds any potential benefit - set us up to remove the assocs from the module to the method queue, which will allow us to deprecate `synthesize methodQueue` and `-(dispatch_queue_t)moduleQueue` API. in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue. Reviewed By: cipolleschi Differential Revision: D50398635
philIip
force-pushed
the
export-D50398635
branch
2 times, most recently
from
aeaef60 to
7a60c0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
philIip
force-pushed
the
export-D50398635
branch
from
7a60c0b to
1e7883e
Compare
Summary: Changelog: [Internal] currently, each native module creates a new module queue if `methodQueue` is not overridden in the native module. we want to see if we can use a single execution queue for a few reasons: - parity with android's queue model - performance: creating so many queues... for what? the overhead of this feels like it exceeds any potential benefit - set us up to remove the assocs from the module to the method queue, which will allow us to deprecate `synthesize methodQueue` and `-(dispatch_queue_t)moduleQueue` API. in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue. Reviewed By: cipolleschi Differential Revision: D50398635
|
This pull request was exported from Phabricator. Differential Revision: D50398635 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 21, 2023
Summary: Changelog: [Internal] currently, each native module creates a new module queue if `methodQueue` is not overridden in the native module. we want to see if we can use a single execution queue for a few reasons: - parity with android's queue model - performance: creating so many queues... for what? the overhead of this feels like it exceeds any potential benefit - set us up to remove the assocs from the module to the method queue, which will allow us to deprecate `synthesize methodQueue` and `-(dispatch_queue_t)moduleQueue` API. in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue. Reviewed By: cipolleschi Differential Revision: D50398635
philIip
force-pushed
the
export-D50398635
branch
from
1e7883e to
550fc3a
Compare
|
This pull request was successfully merged by @philIip in a337fca. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#41042 Changelog: [Internal] currently, each native module creates a new module queue if `methodQueue` is not overridden in the native module. we want to see if we can use a single execution queue for a few reasons: - parity with android's queue model - performance: creating so many queues... for what? the overhead of this feels like it exceeds any potential benefit - set us up to remove the assocs from the module to the method queue, which will allow us to deprecate `synthesize methodQueue` and `-(dispatch_queue_t)moduleQueue` API. in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue. Reviewed By: cipolleschi Differential Revision: D50398635 fbshipit-source-id: 0b194a5ae5269e843c7c537a973ee1d345ce1df4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
currently, each native module creates a new module queue if
methodQueueis not overridden in the native module.we want to see if we can use a single execution queue for a few reasons:
synthesize methodQueueand-(dispatch_queue_t)moduleQueueAPI.in this QE, we just start with replacing the KVO assoc'd queue with the shared module queue.
Differential Revision: D50398635