Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SocketRocket to 0.6.1 (#40774) #40776

Closed

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
The SocketRocket version was upgraded to 0.6.1 on the 0.72-stable branch but for some reason it was not updated in main, causing a downgrade when running pod install with 0.73.0 RC1

Original commit bumping SocketRocket -> 8ce471e

Changelog:

[IOS] [CHANGED] - Bump SocketRocket to 0.6.1

Test Plan: Run rntester locally

Differential Revision: D50133688

Pulled By: arushikesarwani94

Summary:
The SocketRocket version was upgraded to 0.6.1 on the 0.72-stable branch but for some reason it was not updated in main, causing a downgrade when running `pod install` with 0.73.0 RC1

Original commit bumping SocketRocket -> facebook@8ce471e

## Changelog:

[IOS] [CHANGED] - Bump SocketRocket to 0.6.1

Pull Request resolved: facebook#40774

Test Plan: Run rntester locally

Differential Revision: D50133688

Pulled By: arushikesarwani94

fbshipit-source-id: 8a62bb5ef8ef0c5702f75c55cc7a079ab95740aa
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 10, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50133688

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,219,049 -9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,587,243 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5c2ec55
Branch: main

@gabrieldonadel
Copy link
Collaborator

Hi @arushikesarwani94, not sure if you noticed but it seems that this PR is downgrading CocoaPods version in the lock file. I fixed it here (#40774) tho

@cortinico
Copy link
Contributor

Closing as abandoned internally

@cortinico cortinico closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants