Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce logic to invoke sync void method #39970

Closed
wants to merge 1 commit into from

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Oct 6, 2023

Summary:
Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Differential Revision: D49613770

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

@analysis-bot
Copy link

analysis-bot commented Oct 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,218,437 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,586,935 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4e92f60
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

philIip added a commit to philIip/react-native that referenced this pull request Oct 7, 2023
Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Differential Revision: D49613770
philIip added a commit to philIip/react-native that referenced this pull request Oct 9, 2023
Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Differential Revision: D49613770
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

philIip added a commit to philIip/react-native that referenced this pull request Oct 9, 2023
Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Differential Revision: D49613770
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

philIip added a commit to philIip/react-native that referenced this pull request Oct 11, 2023
Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Reviewed By: javache

Differential Revision: D49613770
philIip added a commit to philIip/react-native that referenced this pull request Oct 11, 2023
Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Reviewed By: javache

Differential Revision: D49613770
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

philIip added a commit to philIip/react-native that referenced this pull request Oct 11, 2023
Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Reviewed By: javache

Differential Revision: D49613770
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

Summary:

Changelog: [Internal]

in this diff, i add the logic that makes void return values run synchronously

Reviewed By: javache

Differential Revision: D49613770
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49613770

@github-actions
Copy link

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against e9f3a8b

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b41a2f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants