Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseJavaModule and ReactContextBaseJavaModule #39823

Closed
wants to merge 3 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Oct 5, 2023

Summary:
In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy.

ReactContextBaseJavaModule will be deprecated in the new architecture

Reviewed By: cortinico

Differential Revision: D49930340

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49930340

@analysis-bot
Copy link

analysis-bot commented Oct 5, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,227,261 -6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,599,502 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ec1de61
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49930340

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 5, 2023
Summary:
Pull Request resolved: facebook#39823

In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy.

ReactContextBaseJavaModule will be deprecated in the new architecture

Reviewed By: cortinico

Differential Revision: D49930340

fbshipit-source-id: 695f4267c1409d67b8a63d5609f02d4b50e18567
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49930340

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 9, 2023
Summary:
Pull Request resolved: facebook#39823

In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy.

ReactContextBaseJavaModule will be deprecated in the new architecture

bypass-github-export-checks

Reviewed By: cortinico

Differential Revision: D49930340

fbshipit-source-id: 965316211023cb1db1f7ac7e3af292e84cc2ea43
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against c2bf3e4

…itecture

Summary:
In this diff I'm marking NativeModule.canOverrideExistingModule() as DeprecatedInNewArchitecture.

changelog: [internal] internal

Differential Revision: D49930341

fbshipit-source-id: 59d57924ddff8d5bdd2dfcb4cdd0ebb986d5efb0
Summary:
Update documentation of NativeModule methods

changelog: [internal] internal

Differential Revision: D49930342

fbshipit-source-id: 860ac74f8ae03baed5e2c52831b4e3011424dceb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49930340

Summary:
Pull Request resolved: facebook#39823

In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy.

ReactContextBaseJavaModule will be deprecated in the new architecture

bypass-github-export-checks

Reviewed By: cortinico

Differential Revision: D49930340

fbshipit-source-id: c56fda685382a8f5cf549533687c9c9bb843316b
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5af7b70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants