-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn CXX implementation of TextLayoutManager into interface #39805
Conversation
This pull request was exported from Phabricator. Differential Revision: D49907594 |
This pull request was exported from Phabricator. Differential Revision: D49907594 |
…#39805) Summary: Pull Request resolved: facebook#39805 ## Changelog: [Internal] - This makes corresponsing text measure methods inside `TextLayoutManager` overridable, so that it can be substituted with a custom implementation without introducing a new "platform". Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there. An alternative could be making `TextLayoutManager` an interface across all the platforms, and actual implementations called e.g. `TextLayoutManagerImpl` in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS. Differential Revision: D49907594 fbshipit-source-id: c42cf4cd93607ccfd7aed44f15cce300814de233
114629a
to
82c4edc
Compare
This pull request was exported from Phabricator. Differential Revision: D49907594 |
…#39805) Summary: Pull Request resolved: facebook#39805 ## Changelog: [Internal] - This makes corresponsing text measure methods inside `TextLayoutManager` overridable, so that it can be substituted with a custom implementation without introducing a new "platform". Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there. An alternative could be making `TextLayoutManager` an interface across all the platforms, and actual implementations called e.g. `TextLayoutManagerImpl` in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS. Differential Revision: D49907594 fbshipit-source-id: 565020f83a3f9e6af2f8b04580b519f9ecca26e5
82c4edc
to
1c8776b
Compare
This pull request was exported from Phabricator. Differential Revision: D49907594 |
…#39805) Summary: Pull Request resolved: facebook#39805 ## Changelog: [Internal] - This makes corresponsing text measure methods inside `TextLayoutManager` overridable, so that it can be substituted with a custom implementation without introducing a new "platform". Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there. An alternative could be making `TextLayoutManager` an interface across all the platforms, and actual implementations called e.g. `TextLayoutManagerImpl` in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS. Differential Revision: D49907594 fbshipit-source-id: b0e5e37a5dcd2312abc3d499fa10a02f88713307
1c8776b
to
867f757
Compare
This pull request was exported from Phabricator. Differential Revision: D49907594 |
…#39805) Summary: Pull Request resolved: facebook#39805 ## Changelog: [Internal] - This makes corresponsing text measure methods inside `TextLayoutManager` overridable, so that it can be substituted with a custom implementation without introducing a new "platform". Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there. An alternative could be making `TextLayoutManager` an interface across all the platforms, and actual implementations called e.g. `TextLayoutManagerImpl` in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS. Differential Revision: D49907594 fbshipit-source-id: 8ec10f22b3ea78cc2e92069c43c159c07b91fc93
867f757
to
26686e3
Compare
Base commit: 2000acc |
This pull request was exported from Phabricator. Differential Revision: D49907594 |
26686e3
to
5aac612
Compare
…#39805) Summary: Pull Request resolved: facebook#39805 ## Changelog: [Internal] - This makes corresponsing text measure methods inside `TextLayoutManager` overridable, so that it can be substituted with a custom implementation without introducing a new "platform". Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there. An alternative could be making `TextLayoutManager` an interface across all the platforms, and actual implementations called e.g. `TextLayoutManagerImpl` in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS. Differential Revision: D49907594 fbshipit-source-id: 71b177107db706ad3245c043ddc13828ac0716fd
…#39805) Summary: ## Changelog: [Internal] - This makes corresponsing text measure methods inside `TextLayoutManager` overridable, so that it can be substituted with a custom implementation without introducing a new "platform". Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there. An alternative could be making `TextLayoutManager` an interface across all the platforms, and actual implementations called e.g. `TextLayoutManagerImpl` in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS. Reviewed By: christophpurrer Differential Revision: D49907594
5aac612
to
7baedd0
Compare
This pull request was exported from Phabricator. Differential Revision: D49907594 |
This pull request has been merged in c969d8c. |
Summary:
Changelog:
[Internal] -
This makes corresponsing text measure methods inside
TextLayoutManager
overridable, so that it can be substituted with a custom implementation without introducing a new "platform".Rationale: CXX platform is rather general and less specific than Android or iOS, so we may potentially have multiple alternative implementations of text layout there.
An alternative could be making
TextLayoutManager
an interface across all the platforms, and actual implementations called e.g.TextLayoutManagerImpl
in each of them, however this would be quite a bit bigger blast radius without much added benefit for Android/iOS.Differential Revision: D49907594