[Local] Xcode 15 patch #39754
Merged
[Local] Xcode 15 patch #39754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Oct 2, 2023
scripts/cocoapods/utils.rb
Outdated
|
|
||
| trimmed_value = value.strip() | ||
| if !old_config.include?(trimmed_value) | ||
| config.build_settings[setting_name] = "#{old_config.strip()} #{trimmed_value}".strip() | ||
| end | ||
| end | ||
|
|
||
| def self.remove_value_to_setting_if_present(config, setting_name, value) |
There was a problem hiding this comment.
Suggested change
| def self.remove_value_to_setting_if_present(config, setting_name, value) | |
| def self.remove_value_from_setting_if_present(config, setting_name, value) |
fortmarek
force-pushed
the
mf/xcode-15-patch
branch
from
da6ac72
to
ce0ff34
Compare
cipolleschi
approved these changes
Oct 3, 2023
|
You might want to run |
fortmarek
force-pushed
the
mf/xcode-15-patch
branch
from
ce0ff34
to
6676ca9
Compare
fortmarek
force-pushed
the
mf/xcode-15-patch
branch
from
f6850e5
to
64f34a6
Compare
cipolleschi
approved these changes
Oct 4, 2023
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Applying this PR from @cipolleschi. We couldn't directly cherry-pick as the files have moved, so doing this to be safe.
Changelog:
[Internal] [Fixed] - Make the Xcode 15 workaround more robust.
Test Plan:
Try out
rn-testerwith Xcode 15.