Reduce visibility of DynamicFromMap #39739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49752137 |
|
This pull request was exported from Phabricator. Differential Revision: D49752137 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39739 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Reviewed By: RSNara Differential Revision: D49752137 fbshipit-source-id: c8038987280e74bb5456cc6e2138eb4bde262647
mdvacca
force-pushed
the
export-D49752137
branch
from
d7d52de to
2626395
Compare
Base commit: 294c0fa |
|
This pull request was exported from Phabricator. Differential Revision: D49752137 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39739 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Reviewed By: RSNara Differential Revision: D49752137 fbshipit-source-id: a192dba7e48629b62e191b7879e65204ed93d4ef
mdvacca
force-pushed
the
export-D49752137
branch
from
2626395 to
a29ec01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752137 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39739 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Reviewed By: RSNara Differential Revision: D49752137 fbshipit-source-id: 38c68cd2eaf598c502cf8882b4701aa0efa34eb3
mdvacca
force-pushed
the
export-D49752137
branch
from
a29ec01 to
39f59e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752137 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39739 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Reviewed By: RSNara Differential Revision: D49752137 fbshipit-source-id: 89f22b999a300b4d20f60fa6901ed9a3aac26789
mdvacca
force-pushed
the
export-D49752137
branch
from
39f59e8 to
cffe40a
Compare
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromArray Differential Revision: D49752134 fbshipit-source-id: 9275ab27ecd39db155dd6e3f9ddaa7ca21932ce5
|
This pull request was exported from Phabricator. Differential Revision: D49752137 |
Summary: Pull Request resolved: facebook#39739 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Reviewed By: RSNara Differential Revision: D49752137 fbshipit-source-id: c2bfcf8dd57521dd45da53e2bbf50cd66e686176
mdvacca
force-pushed
the
export-D49752137
branch
from
cffe40a to
476c566
Compare
|
This pull request has been merged in 7a5824b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of DynamicFromMap
Reviewed By: RSNara
Differential Revision: D49752137