Remove support for Android API < 23 in ReactViewManager #39678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 0b4dc462e5f16f6275f33f41feeb1d521d12d5be
mdvacca
force-pushed
the
export-D48545513
branch
from
4d06f27 to
4ed1128
Compare
Base commit: 5be6f49 |
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 0ef7a6fc681573f280b0ab8f5e7187bbd7c87802
mdvacca
force-pushed
the
export-D48545513
branch
from
4ed1128 to
f52ee6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: b52975d9d0ef2a3766c41325326bc4a13ec4277a
mdvacca
force-pushed
the
export-D48545513
branch
from
f52ee6e to
2a8199d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 66325dbf226e4a98c0acd95f4f7a8346cb11d223
mdvacca
force-pushed
the
export-D48545513
branch
from
2a8199d to
91a929a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 8e28c452c43e79663f55e3ab543b422dc44a2ca2
mdvacca
force-pushed
the
export-D48545513
branch
from
91a929a to
ae6d031
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 945b3805f72ea37555d9aca6b6d3dbc84d6e0207
mdvacca
force-pushed
the
export-D48545513
branch
from
ae6d031 to
ba4e7f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 62ccca9e4b030666d0378fc9afca51e3e5c05817
mdvacca
force-pushed
the
export-D48545513
branch
from
ba4e7f3 to
6470457
Compare
|
Unsubscribe
William Pope Jr
…On Tue, Sep 26, 2023, 2:05 PM David Vacca ***@***.***> wrote:
Summary:
Since minsdk version was increased to 23, we are deleting code using
Android APIs < 23 for class ReactViewManager
chnagelog: [Android][Breaking] Remove support for Android API < 23 in
ReactViewManager
Reviewed By: NickGerleman
Differential Revision: D48545513
------------------------------
You can view, comment on, or merge this pull request online at:
#39678
Commit Summary
- 5b0e5a4
<5b0e5a4>
Bump minSdk to 23 in RN OSS
- 5f9ec6c
<5f9ec6c>
Remove usage of Android API <23 in ReactActivityDelegate
- 43cdc39
<43cdc39>
Remove support for Android API < 23 in ReactFragment
- 9320551
<9320551>
Remove support for Android API < 23 in DebugOverlayController
- c4af34e
<c4af34e>
Remove support for Android API < 23 in WindowOverlayCompat
- 4730320
<4730320>
Remove support for Android API < 23 in RequestBodyUtil
- 3d8afd1
<3d8afd1>
Remove support for Android API < 23 in PermissionsModule
- 4bcbe8d
<4bcbe8d>
Remove support for Android API < 23 in StatusBarModule
- f7df096
<f7df096>
Remove support for Android API < 23 in ReactBaseTextShadowNode
- 2a80c40
<2a80c40>
Remove support for Android API < 23 in ReactTextAnchorViewManager
- 103f0ef
<103f0ef>
Remove support for Android API < 23 in ReactTextShadowNode
- 5accb4f
<5accb4f>
Remove support for Android API < 23 in ReactTextView
- 87078d4
<87078d4>
Remove support for Android API < 23 in TextAttributeProps
- 5c96461
<5c96461>
Remove support for Android API < 23 in TextLayoutManager
- ebb15a1
<ebb15a1>
Remove support for Android API < 23 in TextLayoutManagerMapBuffer
- 891faf2
<891faf2>
Remove support for Android API < 23 in ReactEditText
- 74d6cd2
<74d6cd2>
Remove support for Android API < 23 in ReactTextInputLocalData
- 127d8cb
<127d8cb>
Remove support for Android API < 23 in ReactTextInputShadowNode
- 01e8d53
<01e8d53>
Remove support for Android API < 23 in ReactDrawableHelper
- 4d06f27
<4d06f27>
Remove support for Android API < 23 in ReactViewManager
File Changes
(22 files <https://github.com/facebook/react-native/pull/39678/files>)
- *M* packages/react-native/ReactAndroid/src/main/AndroidManifest.xml
<https://github.com/facebook/react-native/pull/39678/files#diff-7736a5e2c4b1188526e73e5cac5746c9ff9f2596237d7d13da3f9e7512417173>
(2)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
<https://github.com/facebook/react-native/pull/39678/files#diff-ef5f96c43a5cbb0fee8567bc29a91fb32a04a243a6779d714486b26f5df6e904>
(3)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactFragment.java
<https://github.com/facebook/react-native/pull/39678/files#diff-e9db71ab72450ab94a066322c3c79910428fa971b8943ef442d4b378ea86a091>
(4)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DebugOverlayController.java
<https://github.com/facebook/react-native/pull/39678/files#diff-bf395c721d44a29493729e0f1cabc0b8ae5345189117e5aada8c8243af00728a>
(41)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/WindowOverlayCompat.java
<https://github.com/facebook/react-native/pull/39678/files#diff-6f3567807806e8f57fb8596c088c07a6d7aa360291fb4ef5bf38e726823801b2>
(7)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/RequestBodyUtil.java
<https://github.com/facebook/react-native/pull/39678/files#diff-b71c8a961e3225745ecd87d70db73cad56c2610017525c36559be317c50fe60d>
(27)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/PermissionsModule.java
<https://github.com/facebook/react-native/pull/39678/files#diff-4b1863674dcd368c1af4cdd6073be6f8df7c77d10e67609f2529f778fae4a1e6>
(30)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/StatusBarModule.java
<https://github.com/facebook/react-native/pull/39678/files#diff-f8fa0e99b36a5dafd803c629aedc9ec031c8bf1e11a84342a2bb2d4e744801f2>
(2)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java
<https://github.com/facebook/react-native/pull/39678/files#diff-1e89b4749239cc06ee0fe072cfbe34b91e31d43a1bcf5beb0ae6bf57d5ea49f9>
(21)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java
<https://github.com/facebook/react-native/pull/39678/files#diff-bebf9c0aee0e96d7bd5fef66469e4d42b8f88e80b8de811c63b8fcdcfe688de7>
(5)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java
<https://github.com/facebook/react-native/pull/39678/files#diff-d23b21c0d9db272ae998c5cb18c1b4bd3014afca1ccc72e00f55a231b1f35e12>
(80)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
<https://github.com/facebook/react-native/pull/39678/files#diff-be5d70f304b1848255d7abab801af5e7c0b69b476d8372e2fc8618c43b0482ea>
(15)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java
<https://github.com/facebook/react-native/pull/39678/files#diff-b9e0570c60cc250d58c813271476c3d19dce1d05e96e7dd5567551416b99a1d0>
(6)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java
<https://github.com/facebook/react-native/pull/39678/files#diff-e53011726a0eaf0dd8acab115a5e380e2b6d5e5e7504e1825bbce8418c1c91cb>
(67)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java
<https://github.com/facebook/react-native/pull/39678/files#diff-4d82e5dd5624efb086abab9031aa644e7ce3a79b0553394962a25f479ed2f344>
(67)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java
<https://github.com/facebook/react-native/pull/39678/files#diff-e14e9099724d0087bcf9e2847733e8a132fbcb18c5f0d77d8867ff30528c704e>
(33)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputLocalData.java
<https://github.com/facebook/react-native/pull/39678/files#diff-39ee41f8481ad9b858436991c2190f44fc15cc94e6537a79bd251b6288e66c1c>
(12)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java
<https://github.com/facebook/react-native/pull/39678/files#diff-2f468757087a2257fc913fbb7b016925b6ae965afd882436715dcd1264418a41>
(15)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactDrawableHelper.java
<https://github.com/facebook/react-native/pull/39678/files#diff-0670437eb832fd8e3087556cf713b92c95db6d2aae15c304554aa19e97dfb526>
(5)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java
<https://github.com/facebook/react-native/pull/39678/files#diff-cb58c3e69d1fc2e20807be258624a1955c60af61f2e7aede2386427c0682e91e>
(3)
- *M* packages/react-native/gradle/libs.versions.toml
<https://github.com/facebook/react-native/pull/39678/files#diff-8465d9c970e5f30f52e682b477e1e5e16bc63c2e98b854f5e50320784fbfff27>
(2)
- *M* packages/react-native/template/android/build.gradle
<https://github.com/facebook/react-native/pull/39678/files#diff-70e8bbcfe1192b2049daab4af55b99b05a2123d272d4f147698d51caeb5f3ae6>
(2)
Patch Links:
- https://github.com/facebook/react-native/pull/39678.patch
- https://github.com/facebook/react-native/pull/39678.diff
—
Reply to this email directly, view it on GitHub
<#39678>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALNSC3D7JWAE5ZA36SZGQOLX4MKPLANCNFSM6AAAAAA5IDZCC4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: fed98f9476cf95e107853cdaeb07f483ec87739c
mdvacca
force-pushed
the
export-D48545513
branch
from
e27a63e to
0aad374
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 7c57a9ea850c0de012912a6454e8c282088e8b25
mdvacca
force-pushed
the
export-D48545513
branch
from
0aad374 to
8c5b52b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 1a20f14532d8bf12943987ff9a19596ef8d21066
mdvacca
force-pushed
the
export-D48545513
branch
from
8c5b52b to
2ffa6e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 29, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 4050811b6026cce98764f6c82070bce4297e8201
mdvacca
force-pushed
the
export-D48545513
branch
from
2ffa6e7 to
c5482af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 29, 2023
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 330d2e6784990c4c0f2526ac7981e710a08c068c
mdvacca
force-pushed
the
export-D48545513
branch
from
c5482af to
2a53bb3
Compare
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextShadowNode Differential Revision: D48545511 fbshipit-source-id: 68e887ea02193fbb0b6e706d0f868029ee7063fb
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextView chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextView Differential Revision: D48545504 fbshipit-source-id: 769e0141365bdf1e98da7835afa3bf4ccff568f3
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextAttributeProps chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextAttributeProps Differential Revision: D48545514 fbshipit-source-id: 366f3ebac9d77fd58afcf6060a0043a12c903bab
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager Differential Revision: D48545502 fbshipit-source-id: 6b70a9b5cf68efc5f9ebad6c7c1f78c1f6efb141
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManagerMapBuffer chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManagerMapBuffer Differential Revision: D48545518 fbshipit-source-id: 7158be914604d0f8d271ff754a8a864be18e1fa9
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText Differential Revision: D48545507 fbshipit-source-id: da6e758420305119d30e73cfc0b7a44efe90ecc7
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputLocalData chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputLocalData Differential Revision: D48545510 fbshipit-source-id: bd9004cf9f8b741ff0655555b8a9afa3f66f1594
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputShadowNode Differential Revision: D48545503 fbshipit-source-id: 6ee922970c9983a2fba27028df02a3c63700d996
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactDrawableHelper chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactDrawableHelper Differential Revision: D48545508 fbshipit-source-id: ca98c4dae65101dca78ac78bd5af7950fe5167a9
|
This pull request was exported from Phabricator. Differential Revision: D48545513 |
Summary: Pull Request resolved: facebook#39678 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager Reviewed By: NickGerleman Differential Revision: D48545513 fbshipit-source-id: 792826fd44e756afcd4659a95212e82f256525e3
mdvacca
force-pushed
the
export-D48545513
branch
from
2a53bb3 to
64ad64a
Compare
|
This pull request has been merged in cb46f4c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactViewManager
chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactViewManager
Reviewed By: NickGerleman
Differential Revision: D48545513