Remove support for Android API < 23 in ReactTextAnchorViewManager #39676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 2b3596b17904bdbbdf2ea23ccb2d65097221504b
mdvacca
force-pushed
the
export-D48545519
branch
from
f8210ae to
6432edf
Compare
Base commit: 0b1fcfb |
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 2e8be4f2d4287d9de295ce5f46345601bdf0e614
mdvacca
force-pushed
the
export-D48545519
branch
from
6432edf to
7bbb590
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 3664414c27dd49ba7f241a9ab03eaf715c58ef18
mdvacca
force-pushed
the
export-D48545519
branch
from
7bbb590 to
d75a680
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 3eed82e368c7a29f190ac6a1466274f440d039a2
mdvacca
force-pushed
the
export-D48545519
branch
from
d75a680 to
feeacfe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 62caa0755f7cb80310392f33cc7bdcc171be2a42
mdvacca
force-pushed
the
export-D48545519
branch
from
feeacfe to
c90c892
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: de1426170f3e484d83e0873bceed91aa4e96ef7b
mdvacca
force-pushed
the
export-D48545519
branch
from
c90c892 to
e3f3a56
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 28, 2023
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 5b015e112caba5c3e0b77db93aedfbee192410c7
mdvacca
force-pushed
the
export-D48545519
branch
from
e3f3a56 to
0d07339
Compare
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Differential Revision: D48545509 fbshipit-source-id: 86f86e55206e24cbf6e190e82b0c84cd69111dca
|
This pull request was exported from Phabricator. Differential Revision: D48545519 |
…cebook#39676) Summary: Pull Request resolved: facebook#39676 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager changelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager Reviewed By: NickGerleman Differential Revision: D48545519 fbshipit-source-id: 919e0ab93ce1c88340647775065fc9e45fa9e395
mdvacca
force-pushed
the
export-D48545519
branch
from
0d07339 to
146959e
Compare
|
This pull request has been merged in b138a4f. |
|
Unsubscribe
William Pope Jr
…On Tue, Sep 26, 2023, 2:04 PM David Vacca ***@***.***> wrote:
Summary:
Since minsdk version was increased to 23, we are deleting code using
Android APIs < 23 for class ReactTextAnchorViewManager
chnagelog: [Android][Breaking] Remove support for Android API < 23 in
ReactTextAnchorViewManager
Reviewed By: NickGerleman
Differential Revision: D48545519
------------------------------
You can view, comment on, or merge this pull request online at:
#39676
Commit Summary
- 7a06e76
<7a06e76>
Bump minSdk to 23 in RN OSS
- 3f3262e
<3f3262e>
Remove usage of Android API <23 in ReactActivityDelegate
- f4dbb73
<f4dbb73>
Remove support for Android API < 23 in ReactFragment
- 18ca878
<18ca878>
Remove support for Android API < 23 in DebugOverlayController
- b44e683
<b44e683>
Remove support for Android API < 23 in WindowOverlayCompat
- 11acec4
<11acec4>
Remove support for Android API < 23 in RequestBodyUtil
- 3748824
<3748824>
Remove support for Android API < 23 in PermissionsModule
- 7476885
<7476885>
Remove support for Android API < 23 in StatusBarModule
- 34b22c0
<34b22c0>
Remove support for Android API < 23 in ReactBaseTextShadowNode
- f8210ae
<f8210ae>
Remove support for Android API < 23 in ReactTextAnchorViewManager
File Changes
(12 files <https://github.com/facebook/react-native/pull/39676/files>)
- *M* packages/react-native/ReactAndroid/src/main/AndroidManifest.xml
<https://github.com/facebook/react-native/pull/39676/files#diff-7736a5e2c4b1188526e73e5cac5746c9ff9f2596237d7d13da3f9e7512417173>
(2)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
<https://github.com/facebook/react-native/pull/39676/files#diff-ef5f96c43a5cbb0fee8567bc29a91fb32a04a243a6779d714486b26f5df6e904>
(3)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactFragment.java
<https://github.com/facebook/react-native/pull/39676/files#diff-e9db71ab72450ab94a066322c3c79910428fa971b8943ef442d4b378ea86a091>
(4)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DebugOverlayController.java
<https://github.com/facebook/react-native/pull/39676/files#diff-bf395c721d44a29493729e0f1cabc0b8ae5345189117e5aada8c8243af00728a>
(41)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/WindowOverlayCompat.java
<https://github.com/facebook/react-native/pull/39676/files#diff-6f3567807806e8f57fb8596c088c07a6d7aa360291fb4ef5bf38e726823801b2>
(7)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/RequestBodyUtil.java
<https://github.com/facebook/react-native/pull/39676/files#diff-b71c8a961e3225745ecd87d70db73cad56c2610017525c36559be317c50fe60d>
(27)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/permissions/PermissionsModule.java
<https://github.com/facebook/react-native/pull/39676/files#diff-4b1863674dcd368c1af4cdd6073be6f8df7c77d10e67609f2529f778fae4a1e6>
(30)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/StatusBarModule.java
<https://github.com/facebook/react-native/pull/39676/files#diff-f8fa0e99b36a5dafd803c629aedc9ec031c8bf1e11a84342a2bb2d4e744801f2>
(2)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java
<https://github.com/facebook/react-native/pull/39676/files#diff-1e89b4749239cc06ee0fe072cfbe34b91e31d43a1bcf5beb0ae6bf57d5ea49f9>
(21)
- *M*
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.java
<https://github.com/facebook/react-native/pull/39676/files#diff-bebf9c0aee0e96d7bd5fef66469e4d42b8f88e80b8de811c63b8fcdcfe688de7>
(5)
- *M* packages/react-native/gradle/libs.versions.toml
<https://github.com/facebook/react-native/pull/39676/files#diff-8465d9c970e5f30f52e682b477e1e5e16bc63c2e98b854f5e50320784fbfff27>
(2)
- *M* packages/react-native/template/android/build.gradle
<https://github.com/facebook/react-native/pull/39676/files#diff-70e8bbcfe1192b2049daab4af55b99b05a2123d272d4f147698d51caeb5f3ae6>
(2)
Patch Links:
- https://github.com/facebook/react-native/pull/39676.patch
- https://github.com/facebook/react-native/pull/39676.diff
—
Reply to this email directly, view it on GitHub
<#39676>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALNSC3HPZOVF6CUWUIF7BZLX4MKKNANCNFSM6AAAAAA5IDYHWM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextAnchorViewManager
chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextAnchorViewManager
Reviewed By: NickGerleman
Differential Revision: D48545519