Remove support for Android API < 23 in ReactFragment #39668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
Base commit: 5203354 |
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: 2f267ab73b9560455ebb64cfb824c583927d315f
mdvacca
force-pushed
the
export-D48545506
branch
from
62ee77c to
356675d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: f12cb1f7ad9b398564990f38b910b262c82ab466
mdvacca
force-pushed
the
export-D48545506
branch
from
356675d to
9ef5ec4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: 70c4a2010db6f8d0d137e9e15f77d5119cdc2bbe
mdvacca
force-pushed
the
export-D48545506
branch
from
9ef5ec4 to
bd5aa40
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: ce298b5ed7eb01c5b27b92761d989838a082ad14
mdvacca
force-pushed
the
export-D48545506
branch
from
bd5aa40 to
451291c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment changelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: 76d4e5b90344ad8c4ba88e31143bc9a637b81af6
mdvacca
force-pushed
the
export-D48545506
branch
from
451291c to
06a0041
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment changelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: 1ab7bd7c1cd20a51f0a5650495b8982272a886a4
mdvacca
force-pushed
the
export-D48545506
branch
from
06a0041 to
568f24a
Compare
Summary: In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk changelog: [Android][Breaking] Increase min sdk version of RN Android to 23 Differential Revision: D48177965 fbshipit-source-id: cf47eaee8cb323cd9751f4dc88b47155a28d1415
Summary: Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in chnagelog: [Android][Breaking] Remove support for Android API < 23 in Differential Revision: D48545501 fbshipit-source-id: 5eb84009138ffbb5a6a3a299209fe01162e50961
|
This pull request was exported from Phabricator. Differential Revision: D48545506 |
Summary: Pull Request resolved: facebook#39668 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment changelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Reviewed By: NickGerleman Differential Revision: D48545506 fbshipit-source-id: cbfaef2babd6ed9b065acdc87e7d387258af17f4
mdvacca
force-pushed
the
export-D48545506
branch
from
568f24a to
4a51d18
Compare
|
This pull request has been merged in 414b25b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment
chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment
Reviewed By: NickGerleman
Differential Revision: D48545506