Fix instacrash with RNTester #39631
Closed
Fix instacrash with RNTester #39631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49501328 |
Base commit: 030663b |
|
This pull request was exported from Phabricator. Differential Revision: D49501328 |
luluwu2032
added a commit
to luluwu2032/react-native
that referenced
this pull request
Sep 25, 2023
Summary: Don't display the PopupWindow when current activity is in a bad state, other wise there will be a crash P832378432 Changelog: [Android][Changed] - Don't display the PopupWindow when current activity is in a bad state Reviewed By: mdvacca Differential Revision: D49501328
luluwu2032
force-pushed
the
export-D49501328
branch
from
14dbf01 to
915b57d
Compare
Summary: Don't display the PopupWindow when current activity is in a bad state, other wise there will be a crash P832378432 Changelog: [Android][Changed] - Don't display the PopupWindow when current activity is in a bad state Reviewed By: mdvacca Differential Revision: D49501328
luluwu2032
force-pushed
the
export-D49501328
branch
from
915b57d to
958d600
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49501328 |
|
This pull request was successfully merged by Lulu Wu in cee5dce. When will my fix make it into a release? | Upcoming Releases |
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39631 Don't display the PopupWindow when current activity is in a bad state, other wise there will be a crash P832378432 Changelog: [Android][Changed] - Don't display the PopupWindow when current activity is in a bad state Reviewed By: mdvacca Differential Revision: D49501328 fbshipit-source-id: 1a51855daa470e8da9399f72ca7211a95388e38f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Don't display the PopupWindow when current activity is in a bad state, other wise there will be a crash P832378432
Changelog:
[Android][Changed] - Don't display the PopupWindow when current activity is in a bad state
Reviewed By: mdvacca
Differential Revision: D49501328