NIT lint warns fixed in BlobProvider #39614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: 579b53a4c329df6fd4f923ba2f3fec915fe54ee6
mdvacca
force-pushed
the
export-D49483635
branch
from
e93461a to
76296b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: 2eae0ac3f6f82adfd37a6891e7694cc4f56d8b55
mdvacca
force-pushed
the
export-D49483635
branch
from
76296b8 to
a3f8e63
Compare
Base commit: 36057da |
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 23, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: c4fcbd5b92c1a6f84e8e18059fbf32c52c3fc34f
mdvacca
force-pushed
the
export-D49483635
branch
from
a3f8e63 to
6bdff5d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 23, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: b810c31a5172aebbdafdaf1cd593db830868bcaa
mdvacca
force-pushed
the
export-D49483635
branch
from
6bdff5d to
b7d48fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 23, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: 927ecb4270e48189fb6bcd74c6049bbdb7695398
mdvacca
force-pushed
the
export-D49483635
branch
from
b7d48fc to
1b52757
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 24, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: 24665e730b3b4aec3786e2f65acb722adef68a8c
mdvacca
force-pushed
the
export-D49483635
branch
from
1b52757 to
36b0e30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: d2cd188d790ff9bbee4ca11db11e6e85d3eaa63c
mdvacca
force-pushed
the
export-D49483635
branch
from
36b0e30 to
470b333
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: 2edfad0bb81c070b6fda14f9903a2f216fe313d5
mdvacca
force-pushed
the
export-D49483635
branch
from
470b333 to
2c0df2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: 42be2e328d1cf73eecb3d708e77ce7bf5544388a
mdvacca
force-pushed
the
export-D49483635
branch
from
2c0df2b to
54b3d42
Compare
Summary: I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Differential Revision: D49469208 fbshipit-source-id: c7807ff0686e0289e71db494c553d2f5b63d6efb
Summary: I'm removing mTurboModuleManagerJSIModule from CatalystInstanceImpl, as this is a duplicated variable. changelog: [internal] internal Differential Revision: D49483637 fbshipit-source-id: 28d6ad4db3f8d51974e7bd1ad8a5c25437710a36
|
This pull request was exported from Phabricator. Differential Revision: D49483635 |
Summary: Pull Request resolved: facebook#39614 NIT lint warns fixed in BlobProvider changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D49483635 fbshipit-source-id: e097a8575c6e53d7270d200cdff11988c5f63356
mdvacca
force-pushed
the
export-D49483635
branch
from
54b3d42 to
710ef42
Compare
|
This pull request has been merged in 5203354. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NIT lint warns fixed in BlobProvider
changelog: [internal] internal
Reviewed By: christophpurrer
Differential Revision: D49483635