Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to parametrize executors to use the min Xcode version for some jobs #39602

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

App can be submitted to the app store by using Xcode 14.1 as min Xcode version.
Right now we are testing everything against the latests Xcode, but it would be good to have some tests to check that we don't break the flow for people stuck on older Xcodes.
We already had issues like these in the past, unfortunately.

Plus, we are making some changes using C++20 which we don't know whether they are properly supported by older versions of Xcode.
This change should give us confidence on those changes too.

Changelog:

[Internal] - Use Xcode 14.1 for some tests

Test Plan:

CircleCI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 22, 2023
@cipolleschi cipolleschi force-pushed the cipolleschi/add_job_with_Xcode14.1 branch from 604fcec to ecbe2af Compare September 22, 2023 10:47
@analysis-bot
Copy link

analysis-bot commented Sep 22, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,649,161 +2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,026,704 -40
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e8a0f0d
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/add_job_with_Xcode14.1 branch 2 times, most recently from 06b2949 to 7fe9e18 Compare September 22, 2023 14:12
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/add_job_with_Xcode14.1 branch from 7fe9e18 to 43daf79 Compare October 23, 2023 09:22
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/add_job_with_Xcode14.1 branch from 43daf79 to 132020e Compare October 23, 2023 09:45
@cipolleschi cipolleschi force-pushed the cipolleschi/add_job_with_Xcode14.1 branch from 132020e to 2899299 Compare October 23, 2023 10:08
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 132020e

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 23, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in fdd62e9.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Oct 30, 2023
…bs (facebook#39602)

Summary:
App can be submitted to the app store by using Xcode 14.1 as min Xcode version.
Right now we are testing everything against the latests Xcode, but it would be good to have some tests to check that we don't break the flow for people stuck on older Xcodes.
We already had issues like these in the past, unfortunately.

Plus, we are making some changes using C++20 which we don't know whether they are properly supported by older versions of Xcode.
This change should give us confidence on those changes too.

## Changelog:
[Internal] - Use Xcode 14.1 for some tests

Pull Request resolved: facebook#39602

Test Plan: CircleCI is green

Reviewed By: NickGerleman

Differential Revision: D49540292

Pulled By: cipolleschi

fbshipit-source-id: 71c07293598fd5b1f73f6d7d9425f385aa12fc4e
@cortinico cortinico deleted the cipolleschi/add_job_with_Xcode14.1 branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants