-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of Gutters arrays and YGGutter as index #39597
Conversation
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Base commit: f174f02 |
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 3dc06bb17e9c2d4b373d66cfb2ee6c34921a5be5
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: e4c4e2702ab9fff345b2227d5f078ddf13c0fdc1
21fb77e
to
69790e6
Compare
This pull request was exported from Phabricator. Differential Revision: D49530923 |
69790e6
to
d516aeb
Compare
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 9a12dd475febd50e3c52b35c15c040bf038ffe9a
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 651b2937ef1eefc2885dc517a80d819af885f97b
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 3fe0dcdd7f78339b9c4af352df6eed4171fab0d7
d516aeb
to
7c739d8
Compare
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: cd7064c70cee9715625d17746b805f6269ab825e
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: a4ebbf52d7f62ad2d50248932b3ba340df3dcfb3
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 6d703fd06a37f2ec9df4da4a7209b8ca2babdce6
7c739d8
to
2026aa4
Compare
Summary: X-link: facebook/react-native#39597 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
Summary: X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
2026aa4
to
af6720d
Compare
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
af6720d
to
c76a222
Compare
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
Summary: X-link: facebook/react-native#39597 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
c76a222
to
6b44f59
Compare
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: X-link: facebook/react-native#39597 Pull Request resolved: #1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923 fbshipit-source-id: 47b06a7301fb283acc493dba159f496159d59580
This pull request was successfully merged by @NickGerleman in 4da0d44. When will my fix make it into a release? | Upcoming Releases |
Summary: X-link: facebook/react-native#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923 fbshipit-source-id: 47b06a7301fb283acc493dba159f496159d59580
Summary:
Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying.
This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later.
Differential Revision: D49530923