New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style resolution functions returning FloatOptional #39595

Closed

NickGerleman wants to merge 1 commit into facebook:main from NickGerleman:export-D49531421

Contributor

NickGerleman commented Sep 22, 2023

Summary: These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return float instead of FloatOptional, and do some additional cleanup.

Differential Revision: D49531421

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Sep 22, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

facebook-github-bot added the fb-exported label

analysis-bot commented Sep 22, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,901,398	-818
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,380,170	-814
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 5dedf27
Branch: main

Contributor

facebook-github-bot commented Sep 22, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

dd4491b

Summary:
Pull Request resolved: facebook#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Differential Revision: D49531421

fbshipit-source-id: 3057e58cdd112a0cb87b1e920aef9c6010954a31

NickGerleman force-pushed the export-D49531421 branch from 10a1212 to dd4491b Compare

September 22, 2023 08:58

Contributor

facebook-github-bot commented Sep 22, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

d1d8275

Summary:
Pull Request resolved: facebook#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Differential Revision: D49531421

fbshipit-source-id: 6e12f43410ada6b85d57083d4bc690395554367f

NickGerleman force-pushed the export-D49531421 branch from dd4491b to d1d8275 Compare

September 22, 2023 10:11

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

166e516

Summary:
Pull Request resolved: facebook#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Differential Revision: D49531421

fbshipit-source-id: 209eb8d7b8f8e9d3479a83e764b4b3d3a964b463

NickGerleman force-pushed the export-D49531421 branch from d1d8275 to 166e516 Compare

September 26, 2023 03:25

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

b9f3c0f

Summary:
Pull Request resolved: facebook#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Differential Revision: D49531421

fbshipit-source-id: 809ec7c722122074ebdaa689ace52f1dc43048b9

NickGerleman force-pushed the export-D49531421 branch from 166e516 to b9f3c0f Compare

September 26, 2023 03:31

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

f7fd6fa

Summary:
Pull Request resolved: facebook#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Differential Revision: D49531421

fbshipit-source-id: 4f38d5e205d2356faf8bd456667a2f3c520d0728

NickGerleman force-pushed the export-D49531421 branch from b9f3c0f to f7fd6fa Compare

September 28, 2023 21:44

Contributor

facebook-github-bot commented Oct 3, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

a34d4c5

Summary:
Pull Request resolved: facebook#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

fbshipit-source-id: affb992588dbeede66d49cc476049c2d5cc96408

NickGerleman force-pushed the export-D49531421 branch from f7fd6fa to a34d4c5 Compare

October 3, 2023 14:43

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

6cdc4d9

Summary:

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

NickGerleman force-pushed the export-D49531421 branch from a34d4c5 to 6cdc4d9 Compare

October 3, 2023 19:57

Contributor

facebook-github-bot commented Oct 3, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

539d294

Summary:

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

NickGerleman force-pushed the export-D49531421 branch from 6cdc4d9 to 539d294 Compare

October 3, 2023 19:57

Contributor

facebook-github-bot commented Oct 3, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request


          Fix style resolution functions returning FloatOptional (facebook#39595)

55b7a1a

Summary:

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

NickGerleman force-pushed the export-D49531421 branch from 539d294 to 55b7a1a Compare

October 3, 2023 19:57

Contributor

facebook-github-bot commented Oct 3, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421


          Fix style resolution functions returning FloatOptional (facebook#39595)

0b3ae84

Summary:

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

NickGerleman force-pushed the export-D49531421 branch from 55b7a1a to 0b3ae84 Compare

October 3, 2023 20:36

Contributor

facebook-github-bot commented Oct 3, 2023

This pull request was exported from Phabricator. Differential Revision: D49531421

github-actions bot commented Oct 3, 2023

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 55b7a1a

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request


          Fix style resolution functions returning FloatOptional

2d301c8

Summary:
X-link: facebook/react-native#39595

X-link: facebook/yoga#1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

fbshipit-source-id: 95b21cade74e501dd54c7b6ca667c8c3859c5dae

facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request


          Fix style resolution functions returning FloatOptional (#1404)

Summary:
X-link: facebook/react-native#39595

Pull Request resolved: #1404

These functions all ensure their returns are defined, but return FloatOptional anyway, making their callers have to deal with that possibility. Return `float` instead of `FloatOptional`, and do some additional cleanup.

Reviewed By: rshest

Differential Revision: D49531421

fbshipit-source-id: 95b21cade74e501dd54c7b6ca667c8c3859c5dae

github-actions bot commented Oct 3, 2023

This pull request was successfully merged by @NickGerleman in 72d0fed.

^{When will my fix make it into a release? | Upcoming Releases}

github-actions bot added the Merged label

facebook-github-bot closed this in

72d0fed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner