Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FeatureFlag to gate Stable API for Turbo Module #39479

Closed
wants to merge 1 commit into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 15, 2023

Summary:
The goal of this diff is to create a feature flag that will be used to enable/disable Stable API for Turbo Module.
This featureflag will be used to experiment with the new API in fb4a

changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49212022

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49212022

@analysis-bot
Copy link

analysis-bot commented Sep 15, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,342,440 -27
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,581,271 +15
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 2be409f
Branch: main

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 47b7859

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49212022

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 15, 2023
Summary:

The goal of this diff is to create a feature flag that will be used to enable/disable Stable API for Turbo Module.
This featureflag will be used to experiment with the new API in fb4a


changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49212022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49212022

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 15, 2023
Summary:
Pull Request resolved: facebook#39479

The goal of this diff is to create a feature flag that will be used to enable/disable Stable API for Turbo Module.
This featureflag will be used to experiment with the new API in fb4a

changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49212022

fbshipit-source-id: 7ba882c23449a568dc155b693fc12d900890ca85
Summary:

The goal of this diff is to create a feature flag that will be used to enable/disable Stable API for Turbo Module.
This featureflag will be used to experiment with the new API in fb4a


changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49212022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49212022

@github-actions
Copy link

This pull request was successfully merged by @mdvacca in 4919741.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants