Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all annotation processors derive from ProcessorBase (#958) #39360

Closed
wants to merge 1 commit into from
Closed

Make all annotation processors derive from ProcessorBase (#958) #39360

wants to merge 1 commit into from

Conversation

ianlevesque
Copy link
Contributor

Summary: Pull Request resolved: facebook/litho#958

Differential Revision: D49113071

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@analysis-bot
Copy link

analysis-bot commented Sep 29, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,901,405 -20
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,380,170 -4,095
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c4110d0
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

5 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

@ianlevesque @facebook-github-bot
Make all annotation processors derive from ProcessorBase (#39360)
def2bbb 
Summary:

X-link: facebook/litho#958

Reviewed By: MonaHashem

Differential Revision: D49113071
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49113071

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Oct 4, 2023
@ianlevesque @facebook-github-bot
Make all annotation processors derive from ProcessorBase (#958)
5639861 
Summary:
X-link: facebook/react-native#39360

Pull Request resolved: #958

Reviewed By: MonaHashem

Differential Revision: D49113071

fbshipit-source-id: f762032e0f0b4a1566b0947fe3a24eb32be5795a
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fea445e.

@ianlevesque ianlevesque deleted the export-D49113071 branch October 4, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianlevesque @facebook-github-bot @analysis-bot