ComponentDescriptor::adopt now accepts reference to ShadowNode #39354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49054000 |
Base commit: 247717b |
|
This pull request was exported from Phabricator. Differential Revision: D49054000 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Sep 11, 2023
…ook#39354) Summary: changelog: [internal] Changes `ComponentDescriptor::adopt` to not be protected and it now accepts ShadowNode reference rather than shared_ptr. Differential Revision: D49054000
sammy-SC
force-pushed
the
export-D49054000
branch
from
ac5703c
to
4195c5a
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Sep 11, 2023
…ook#39354) Summary: changelog: [internal] Changes `ComponentDescriptor::adopt` to not be protected and it now accepts ShadowNode reference rather than shared_ptr. Reviewed By: javache Differential Revision: D49054000
sammy-SC
force-pushed
the
export-D49054000
branch
from
4195c5a
to
7bad327
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49054000 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Sep 11, 2023
…ook#39354) Summary: changelog: [internal] Changes `ComponentDescriptor::adopt` to not be protected and it now accepts ShadowNode reference rather than shared_ptr. Reviewed By: javache Differential Revision: D49054000
sammy-SC
force-pushed
the
export-D49054000
branch
from
7bad327
to
378ffd2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49054000 |
…ook#39354) Summary: changelog: [internal] Changes `ComponentDescriptor::adopt` to not be protected and it now accepts ShadowNode reference rather than shared_ptr. Reviewed By: javache Differential Revision: D49054000
sammy-SC
force-pushed
the
export-D49054000
branch
from
378ffd2
to
fbdb955
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49054000 |
|
This pull request was successfully merged by @sammy-SC in 1187720. When will my fix make it into a release? | Upcoming Releases |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Changes
ComponentDescriptor::adoptto not be protected and it now accepts ShadowNode reference rather than shared_ptr.Differential Revision: D49054000