Add 'j' to debug key handler #39256
Closed
Add 'j' to debug key handler #39256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
Base commit: 83885f1 |
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 1, 2023
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 9fc07f4afc8becaf63700eae85a1d447c2564a47
huntie
force-pushed
the
export-D48873335
branch
from
4173807 to
a3b4250
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 1, 2023
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 386710bdc05b5fa325474266fb05d1ffd5ac2382
huntie
force-pushed
the
export-D48873335
branch
from
a3b4250 to
4a477f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 1, 2023
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 0002db509ba3bbba94a0df970fc6d753cab69da2
huntie
force-pushed
the
export-D48873335
branch
from
4a477f8 to
15d3bde
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 3, 2023
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 32b85b89ffc66aaa2be3219a464e308e5ca50ff6
huntie
force-pushed
the
export-D48873335
branch
from
15d3bde to
5331caf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 3, 2023
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 6ab1cc368596dd8d961b40a561da1a8f8cbe8595
huntie
force-pushed
the
export-D48873335
branch
from
5331caf to
02632b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 4, 2023
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 111018ac51bc05f571d4ef40bf1a3bb9871e0b84
huntie
force-pushed
the
export-D48873335
branch
from
02632b4 to
0d9330d
Compare
Differential Revision: https://internalfb.com/D48873336 fbshipit-source-id: 40c408295b5ae9d7d0f1447a6c9f2cfaf5828b36
Summary: Pull Request resolved: facebook#39256 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Adds `j` key handler to open JS debugger (mirroring Expo CLI). - Updates `isDevServerRunning` to consider server scheme and host. - Reorders key prompts. Changelog: [General][Changed] Add 'j' to debug key trigger from CLI Reviewed By: motiz88 Differential Revision: D48873335 fbshipit-source-id: 56b8fa401f3e04928f30f292d4c71445315e9121
|
This pull request was exported from Phabricator. Differential Revision: D48873335 |
huntie
force-pushed
the
export-D48873335
branch
from
0d9330d to
953d42b
Compare
|
This pull request has been merged in 321f7db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
Changes
jkey handler to open JS debugger (mirroring Expo CLI).isDevServerRunningto consider server scheme and host.Changelog:
[General][Changed] Add 'j' to debug key trigger from CLI
Differential Revision: D48873335