Fix crash in CompositeTurboModuleManagerDelegate #39155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
Base commit: 5cfa125 |
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 25, 2023
Summary: Pull Request resolved: facebook#39155 [Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple ``` jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate ``` but don't retain a global reference to them. Fix use: ``` jni::make_global(delegate) ``` Differential Revision: D48670217 fbshipit-source-id: 51e4717187d8b0bdc016b1107960a7911ada163d
christophpurrer
force-pushed
the
export-D48670217
branch
from
992ef4d to
ba72ca6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 25, 2023
Summary: Pull Request resolved: facebook#39155 [Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple ``` jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate ``` but don't retain a global reference to them. Fix use: ``` jni::make_global(delegate) ``` Differential Revision: D48670217 fbshipit-source-id: a04508316923b8d8f687ebe64961809720834ca4
christophpurrer
force-pushed
the
export-D48670217
branch
from
ba72ca6 to
711a236
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 25, 2023
Summary: Pull Request resolved: facebook#39155 [Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple ``` jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate ``` but don't retain a global reference to them. Fix use: ``` jni::make_global(delegate) ``` Differential Revision: D48670217 fbshipit-source-id: 1527016b07dfb37bb853c596527e09dde015b1c3
christophpurrer
force-pushed
the
export-D48670217
branch
from
711a236 to
0c67e63
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 25, 2023
Summary: Pull Request resolved: facebook#39155 [Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple ``` jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate ``` but don't retain a global reference to them. Fix use: ``` jni::make_global(delegate) ``` Differential Revision: D48670217 fbshipit-source-id: d8b081e041ad3047af059138249a306ed8a62ecc
christophpurrer
force-pushed
the
export-D48670217
branch
from
0c67e63 to
39f8c1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 25, 2023
Summary: Pull Request resolved: facebook#39155 [Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple ``` jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate ``` but don't retain a global reference to them. Fix use: ``` jni::make_global(delegate) ``` Differential Revision: D48670217 fbshipit-source-id: eb591cf3a3fb98e5402be742886c34e9ea85c21f
christophpurrer
force-pushed
the
export-D48670217
branch
from
39f8c1f to
38f9b37
Compare
Summary: Pull Request resolved: facebook#39155 [Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple ``` jni::alias_ref<TurboModuleManagerDelegate::javaobject> delegate ``` but don't retain a global reference to them. Fix use: ``` jni::make_global(delegate) ``` Differential Revision: D48670217 fbshipit-source-id: 0c3a099b801c253c95c4b91eb7fb9cbd19fe611a
|
This pull request was exported from Phabricator. Differential Revision: D48670217 |
christophpurrer
force-pushed
the
export-D48670217
branch
from
38f9b37 to
96937a1
Compare
|
This pull request has been merged in e716459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog]: [Android][Fixed] Fix crash in CompositeTurboModuleManagerDelegate
CompositeTurboModuleManagerDelegate.cpp crashes as we pass in one or multiple
but don't retain a global reference to them. Fix use:
Differential Revision: D48670217