Fix concurrent consumers issue with ReactMarker #38710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47933993 |
Base commit: 4b84a2b |
Summary: Pull Request resolved: facebook#38710 Fix a race condition when multiple consumers try to access ReactMarker and trigger calls to native module. Even though ReactMarker uses `ConcurrentLinkedQueue`, the loop itself could race and cause NPE. Changelog: [Android][Fixed] - Fix race condition with ReactMarker calls to its native module Reviewed By: rshest Differential Revision: D47933993 fbshipit-source-id: 502fa95b69aae07444bf48a5f30c094750abed25
ryancat
force-pushed
the
export-D47933993
branch
from
95db149 to
13ad206
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47933993 |
|
This pull request was successfully merged by Xin Chen in 6ab062d. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix a race condition when multiple consumers try to access ReactMarker and trigger calls to native module. Even though ReactMarker uses
ConcurrentLinkedQueue, the loop itself could race and cause NPE.Changelog:
[Android][Fixed] - Fix race condition with ReactMarker calls to its native module
Differential Revision: D47933993