Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check #38639

Closed
wants to merge 1 commit into from

Conversation

dmytrorykun
Copy link
Contributor

Summary:
ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode is a function, we should call it.
Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check

Differential Revision: D47798910

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47798910

@analysis-bot
Copy link

analysis-bot commented Jul 26, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,883,350 -4
android hermes armeabi-v7a 7,934,151 -2
android hermes x86 9,280,424 +1
android hermes x86_64 9,183,543 -1
android jsc arm64-v8a 9,473,063 +0
android jsc armeabi-v7a 8,416,417 -1
android jsc x86 9,455,811 -3
android jsc x86_64 9,772,030 +7

Base commit: e37e530
Branch: main

…heck (facebook#38639)

Summary:
Pull Request resolved: facebook#38639

`ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it.
Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check

Reviewed By: luluwu2032

Differential Revision: D47798910

fbshipit-source-id: 488690006b381c585845d61d8143c3ab16038c8b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47798910

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 75b8b10.

billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
…heck (facebook#38639)

Summary:
Pull Request resolved: facebook#38639

`ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it.
Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check

Reviewed By: luluwu2032

Differential Revision: D47798910

fbshipit-source-id: 68c75069f400f0a0327b1c3a5dd2b1cbfc2e70c7
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
…heck (facebook#38639)

Summary:
Pull Request resolved: facebook#38639

`ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it.
Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check

Reviewed By: luluwu2032

Differential Revision: D47798910

fbshipit-source-id: 68c75069f400f0a0327b1c3a5dd2b1cbfc2e70c7
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
…heck (facebook#38639)

Summary:
Pull Request resolved: facebook#38639

`ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it.
Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check

Reviewed By: luluwu2032

Differential Revision: D47798910

fbshipit-source-id: 68c75069f400f0a0327b1c3a5dd2b1cbfc2e70c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants