-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check #38639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Jul 26, 2023
This pull request was exported from Phabricator. Differential Revision: D47798910 |
Base commit: e37e530 |
…heck (facebook#38639) Summary: Pull Request resolved: facebook#38639 `ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it. Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check Reviewed By: luluwu2032 Differential Revision: D47798910 fbshipit-source-id: 488690006b381c585845d61d8143c3ab16038c8b
This pull request was exported from Phabricator. Differential Revision: D47798910 |
dmytrorykun
force-pushed
the
export-D47798910
branch
from
July 27, 2023 12:20
99f2867
to
49c4a4c
Compare
This pull request has been merged in 75b8b10. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…heck (facebook#38639) Summary: Pull Request resolved: facebook#38639 `ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it. Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check Reviewed By: luluwu2032 Differential Revision: D47798910 fbshipit-source-id: 68c75069f400f0a0327b1c3a5dd2b1cbfc2e70c7
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…heck (facebook#38639) Summary: Pull Request resolved: facebook#38639 `ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it. Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check Reviewed By: luluwu2032 Differential Revision: D47798910 fbshipit-source-id: 68c75069f400f0a0327b1c3a5dd2b1cbfc2e70c7
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…heck (facebook#38639) Summary: Pull Request resolved: facebook#38639 `ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode` is a function, we should call it. Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check Reviewed By: luluwu2032 Differential Revision: D47798910 fbshipit-source-id: 68c75069f400f0a0327b1c3a5dd2b1cbfc2e70c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode
is a function, we should call it.Changelog: [Internal] - Fix ReactNativeFeatureFlags.enableNativeViewConfigsInBridgelessMode check
Differential Revision: D47798910