Remove need for each platform to implement DrawerLayoutAndroid as UnimplementedView #38609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47747205 |
Base commit: e64756a |
|
CC: @Saadnajmi / @chiaramooney |
…mplementedView (facebook#38609) Summary: Pull Request resolved: facebook#38609 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [DrawerAndroid] Remove need for each platform to implement DrawerLayoutAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747205 fbshipit-source-id: 797b58603d93b9ac3b7ac209ffe58ab58db7dd93
|
This pull request was exported from Phabricator. Differential Revision: D47747205 |
christophpurrer
force-pushed
the
export-D47747205
branch
from
041b0ad to
103fabf
Compare
|
This pull request has been merged in 151f390. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…mplementedView (facebook#38609) Summary: Pull Request resolved: facebook#38609 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [DrawerAndroid] Remove need for each platform to implement DrawerLayoutAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747205 fbshipit-source-id: 67d79243d63a5494963330d6edd06749abe6741b
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…mplementedView (facebook#38609) Summary: Pull Request resolved: facebook#38609 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [DrawerAndroid] Remove need for each platform to implement DrawerLayoutAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747205 fbshipit-source-id: 67d79243d63a5494963330d6edd06749abe6741b
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…mplementedView (facebook#38609) Summary: Pull Request resolved: facebook#38609 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [DrawerAndroid] Remove need for each platform to implement DrawerLayoutAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747205 fbshipit-source-id: 67d79243d63a5494963330d6edd06749abe6741b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This file is forked in out of tree platforms as:
The change here removes the need of forking this file
Changelog:
[General] [Fixed] - [DrawerAndroid] Remove need for each platform to implement DrawerLayoutAndroid as UnimplementedView
Differential Revision: D47747205