Fix lint warns #38596
Closed
Fix lint warns #38596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47445900 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebook#38596 Fix lint warns changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D47445900 fbshipit-source-id: 66ca6a8725f18c8410e28c78667cb3cac524a142
mdvacca
force-pushed
the
export-D47445900
branch
from
3cad38a to
ad54b07
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47445900 |
Base commit: 1383a59 |
Summary: In this diff I'm extracting the loading of turbomodulejsijni into its own function. This could have perf implications as we are trying to load multimple times the same soLoader changelog: [intenral] internal Differential Revision: D47409162 fbshipit-source-id: fc84763319dd60d88a7d2842a202324146bc07e7
Summary: Pull Request resolved: facebook#38596 Fix lint warns changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D47445900 fbshipit-source-id: ad129b1938e010ea7227a67f6ff503e3a7ab6cf8
|
This pull request was exported from Phabricator. Differential Revision: D47445900 |
mdvacca
force-pushed
the
export-D47445900
branch
from
ad54b07 to
5e1a321
Compare
|
This pull request has been merged in faae720. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix lint warns
changelog: [internal] internal
Reviewed By: arushikesarwani94
Differential Revision: D47445900