Reduce visibility of JavaMethodWrapper and JavaModuleWrapper to package only #38591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47449525 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jul 25, 2023
…ge only (facebook#38591) Summary: Pull Request resolved: facebook#38591 Reduce visibility of JavaMethodWrapper and JavaModuleWrapper to package only changelog: [internal] internal Reviewed By: christophpurrer, cortinico Differential Revision: D47449525 fbshipit-source-id: a2cbf0187db7ed2c30d768024c1123507d418c33
mdvacca
force-pushed
the
export-D47449525
branch
from
d80f5d0 to
017fd7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47449525 |
Base commit: 1383a59 |
Summary: In this diff I'm extracting the loading of turbomodulejsijni into its own function. This could have perf implications as we are trying to load multimple times the same soLoader changelog: [intenral] internal Differential Revision: D47409162 fbshipit-source-id: a2c67e911863c1258cdd42e27ecf486efe5d7eb8
Summary: Fix lint warns changelog: [internal] internal Differential Revision: D47445900 fbshipit-source-id: f18502744a8bfec74cdb50b11a278951f128c82b
…ge only (facebook#38591) Summary: Pull Request resolved: facebook#38591 Reduce visibility of JavaMethodWrapper and JavaModuleWrapper to package only changelog: [internal] internal Reviewed By: christophpurrer, cortinico Differential Revision: D47449525 fbshipit-source-id: 5af9419d609c9b757ae9ea589f73e1ccf50ab042
|
This pull request was exported from Phabricator. Differential Revision: D47449525 |
mdvacca
force-pushed
the
export-D47449525
branch
from
017fd7c to
05276f6
Compare
|
This pull request has been merged in b77f265. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reduce visibility of JavaMethodWrapper and JavaModuleWrapper to package only
changelog: [internal] internal
Reviewed By: christophpurrer, cortinico
Differential Revision: D47449525