Add init react runtime start time in performance API #38328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43863974 |
Base commit: d380bb8 |
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 17, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 5854a57981a0a6c1c66b773044807d87adc583cd
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 17, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 508cced452b2e0b7dbe5fb60ee91ec630458d88d
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 17, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: d8ea1bd520509e333d07e4be1f9ed253b26ea442
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 17, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: ab21590b050557b61de69024696989df31c82026
ryancat
force-pushed
the
export-D43863974
branch
from
55d4923 to
c0f5fa8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43863974 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D43863974 |
ryancat
force-pushed
the
export-D43863974
branch
from
c0f5fa8 to
2ac5254
Compare
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 26, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 512ab9d1cdfb89fb9605bc53c0186cad60e9d4a8
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 9396e86adc1ece344dd3116670993c5c24303c5f
|
This pull request was exported from Phabricator. Differential Revision: D43863974 |
ryancat
force-pushed
the
export-D43863974
branch
from
2ac5254 to
16cd76a
Compare
|
This pull request was successfully merged by Xin Chen in 10e8b35. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been reverted by ed64018. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 277d35e14dbb5e3def8d440b717b3cf0215b4f47
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 277d35e14dbb5e3def8d440b717b3cf0215b4f47
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and` `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: mdvacca Differential Revision: D43863974 fbshipit-source-id: 277d35e14dbb5e3def8d440b717b3cf0215b4f47
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 8, 2023
Summary: Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: rshest Differential Revision: D47941110 fbshipit-source-id: cba85b91280f4a972ac568f4ec95bca32540f5b4
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: facebook#38858 Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: rshest Differential Revision: D47941110 fbshipit-source-id: 7e925dfeb2482e99d218da5025c21ea53171c87f
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 15, 2023
Summary: Pull Request resolved: facebook#38858 Pull Request resolved: facebook#38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: rshest Differential Revision: D47941110 fbshipit-source-id: 1a589d5e598352a97e5dfacb8ae14a01c46f238a
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: #38858 Pull Request resolved: #38328 This diff adds the two extra markers `initializeRuntimeStart` and `initializeRuntimeEnd` to the startup performance API. The runtime start time matches the existing android marker `GET_REACT_INSTANCE_MANAGER_START`, which is the first marker we have on the RN android app. Changelog: [Android][Added] - Add `performance.reactNativeStartupTiming.initializeRuntimeStart` and `performance.reactNativeStartupTiming.initializeRuntimeEnd` API Reviewed By: rshest Differential Revision: D47941110 fbshipit-source-id: d7e65f822f1c60a46dccacc8fd5bba84174f9f31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the two extra markers
initializeRuntimeStartandinitializeRuntimeEndto the startup performance API. The runtime start time matches the existing android markerGET_REACT_INSTANCE_MANAGER_START, which is the first marker we have on the RN android app.Changelog:
[Android][Added] - Add
performance.reactNativeStartupTiming.initializeRuntimeStartandReviewed By: mdvacca
Differential Revision: D43863974