Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-orgnize BridgelessApple files to keep proper header file include structure #38322

Closed
wants to merge 4 commits into from

Conversation

luluwu2032
Copy link
Contributor

Summary:
As title, so that we can keep the format
#import <ReactCommon/RCTHost.h>

Differential Revision: D47421732

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 12, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47421732

@analysis-bot
Copy link

analysis-bot commented Jul 13, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,833,414 +0
android hermes armeabi-v7a 8,142,471 +1
android hermes x86 9,337,838 +0
android hermes x86_64 9,180,569 +2
android jsc arm64-v8a 9,446,413 +0
android jsc armeabi-v7a 8,627,929 -3
android jsc x86 9,528,601 +1
android jsc x86_64 9,772,067 -2

Base commit: ec1e2af
Branch: main

luluwu2032 and others added 4 commits July 13, 2023 13:07
Differential Revision: https://www.internalfb.com/diff/D46847632?entry_point=27

fbshipit-source-id: bc68d4cdeebf4853b367dc15ffd402d2f8666b94
Differential Revision: D47140743

fbshipit-source-id: 8b95f9f10fcf9fa3d911044185e2e0b4235cafdc
Summary:
This change makes bridgeless build with JSC and with all the frameworks settings.

## Changelog:
[iOS][Added] Support bridgeless with JSC and frameworks

Differential Revision: D47025704

fbshipit-source-id: 36ae357a40a08c86b9a403dea589a8575e972b29
…tructure (facebook#38322)

Summary:
Pull Request resolved: facebook#38322

As title, so that we can keep the format
```#import <ReactCommon/RCTHost.h>```

Differential Revision: D47421732

fbshipit-source-id: b2ecb73da36d5769cad76dc3a33f4d3511648d10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47421732

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 736dd5a.

janicduplessis added a commit to janicduplessis/react-native that referenced this pull request Jul 29, 2023
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
…tructure (facebook#38322)

Summary:
Pull Request resolved: facebook#38322

As title, so that we can keep the format
```#import <ReactCommon/RCTHost.h>```

Changelog:
[iOS][Changed] - ] Re-orgnize BridgelessApple files to keep proper header file include structure

Reviewed By: cipolleschi, dmytrorykun

Differential Revision: D47421732

fbshipit-source-id: af14807d20676e8732c66fa7f792580819c33f33
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
…tructure (facebook#38322)

Summary:
Pull Request resolved: facebook#38322

As title, so that we can keep the format
```#import <ReactCommon/RCTHost.h>```

Changelog:
[iOS][Changed] - ] Re-orgnize BridgelessApple files to keep proper header file include structure

Reviewed By: cipolleschi, dmytrorykun

Differential Revision: D47421732

fbshipit-source-id: af14807d20676e8732c66fa7f792580819c33f33
billnbell pushed a commit to billnbell/react-native that referenced this pull request Jul 29, 2023
…tructure (facebook#38322)

Summary:
Pull Request resolved: facebook#38322

As title, so that we can keep the format
```#import <ReactCommon/RCTHost.h>```

Changelog:
[iOS][Changed] - ] Re-orgnize BridgelessApple files to keep proper header file include structure

Reviewed By: cipolleschi, dmytrorykun

Differential Revision: D47421732

fbshipit-source-id: af14807d20676e8732c66fa7f792580819c33f33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants