Rollout TurboModuleBinding::Prototype #38220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47258286 |
Base commit: 50f620a |
|
This pull request was exported from Phabricator. Differential Revision: D47258286 |
javache
force-pushed
the
export-D47258286
branch
from
5d1579a to
7f4fbd6
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Jul 10, 2023
Summary: Pull Request resolved: facebook#38220 We ran an experiment to test different implementations of TurboModules HostObjects, as the current one has various inefficiencies, such as re-creating HostFunctions on every property access. The strategy we found to be most efficient and flexible longer-term is to represent the TurboModule with a plain JavaScript object and use a HostObject as its prototype. Whenever a property is accessed through the prototype, we cache the property value on the plain object, so it can be efficiently resolved by the VM for future accesses. Changelog: [General] TurboModules are now exposed to JS as the prototype of a plain JS object, so methods can be cached Reviewed By: sammy-SC Differential Revision: D47258286 fbshipit-source-id: 279b32051e5306365ac0f7c03e1d0751d1e26a51
Summary: Pull Request resolved: facebook#38220 We ran an experiment to test different implementations of TurboModules HostObjects, as the current one has various inefficiencies, such as re-creating HostFunctions on every property access. The strategy we found to be most efficient and flexible longer-term is to represent the TurboModule with a plain JavaScript object and use a HostObject as its prototype. Whenever a property is accessed through the prototype, we cache the property value on the plain object, so it can be efficiently resolved by the VM for future accesses. Changelog: [General] TurboModules are now exposed to JS as the prototype of a plain JS object, so methods can be cached Reviewed By: sammy-SC Differential Revision: D47258286 fbshipit-source-id: 8954e16dafb30551dd8c72cd88f800e6be79cce3
|
This pull request was exported from Phabricator. Differential Revision: D47258286 |
javache
force-pushed
the
export-D47258286
branch
from
7f4fbd6 to
1c2f612
Compare
|
This pull request has been merged in 20dba39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We ran an experiment to test different implementations of TurboModules HostObjects, as the current one has various inefficiencies, such as re-creating HostFunctions on every property access. The strategy we found to be most efficient and flexible longer-term is to represent the TurboModule with a plain JavaScript object and use a HostObject as its prototype. Whenever a property is accessed through the prototype, we cache the property value on the plain object, so it can be efficiently resolved by the VM for future accesses.
Changelog: [General] TurboModules are now exposed to JS as the prototype of a plain JS object, so methods can be cached
Differential Revision: D47258286