Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.72] Re-enable direct debugging with JSC on iOS 16.4+ #37922

Closed
wants to merge 1 commit into from

Conversation

Saadnajmi
Copy link
Contributor

Cherry pick of 8b1bf05 to 0.72-stable

Summary:
Pull Request resolved: facebook#37914

Restores facebook#37874 (reverted earlier today), with fix for `JSCRuntime.cpp` build on Android.

Changelog: None

Reviewed By: cortinico

Differential Revision: D46762984

fbshipit-source-id: 6d56f81b9d0c928887860993b2b729ed96c0734c
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jun 15, 2023
@github-actions
Copy link

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 4fc475e

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,545,464 -212,216
android hermes armeabi-v7a 7,859,638 -210,615
android hermes x86 9,024,366 -225,909
android hermes x86_64 8,878,911 -220,502
android jsc arm64-v8a 9,145,051 -173,782
android jsc armeabi-v7a 8,335,015 -173,722
android jsc x86 9,198,310 -184,009
android jsc x86_64 9,455,902 -179,652

Base commit: 8b1bf05
Branch: main

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding blocking comment to avoid that someone would merge it for now: we need to be careful because it seems that JSGlobalContextSetInspectable is only available starting with Xcode 14.3, so this would force folks to upgrade to it.

@kelset
Copy link
Contributor

kelset commented Jun 19, 2023

for further details, check out the conversation here -> reactwg/react-native-releases#73 (comment)

@Saadnajmi
Copy link
Contributor Author

Closing for now, I have a separate PR to make this commit compatible with Xcode 14.2 and If that merges, I'll re-open + pick that too.

@Saadnajmi Saadnajmi closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants