Revert "fix: border width top/bottom not matching the border radius" #37840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
…acebook#34362)" This reverts commit cd6a913.
gabrieldonadel
force-pushed
the
fix-border-calcs
branch
from
dd4178a
to
5a772b7
Compare
gabrieldonadel
changed the title
Base commit: 83d7a48 |
kelset
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
can confirm that this addresses the border problem we have been hitting in 0.72, see here for screenshots
cipolleschi
approved these changes
Jun 13, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 9c9945a. |
kelset
pushed a commit
that referenced
this pull request
Jun 13, 2023
…37840) Summary: In an effort to fix #37753, this PR reverts the changes introduced by cd6a913 and 1d51032 so border-radius width calculations work as expected ## Changelog: [ANDROID] [FIXED] - Fix border-radius width calculations Pull Request resolved: #37840 Test Plan: Test border colors along with border-radius through RNTester <img width="538" alt="image" src="https://github.com/facebook/react-native/assets/11707729/4b148d4b-35dc-4737-be00-c5ff156b0865"> Reviewed By: dmytrorykun Differential Revision: D46684071 Pulled By: cipolleschi fbshipit-source-id: cf7a80d0d63009b457f03d690b632e332a9b4a02
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 15, 2023
…acebook#37840) Summary: In an effort to fix facebook#37753, this PR reverts the changes introduced by facebook@cd6a913 and facebook@1d51032 so border-radius width calculations work as expected ## Changelog: [ANDROID] [FIXED] - Fix border-radius width calculations Pull Request resolved: facebook#37840 Test Plan: Test border colors along with border-radius through RNTester <img width="538" alt="image" src="https://github.com/facebook/react-native/assets/11707729/4b148d4b-35dc-4737-be00-c5ff156b0865"> Reviewed By: dmytrorykun Differential Revision: D46684071 Pulled By: cipolleschi fbshipit-source-id: cf7a80d0d63009b457f03d690b632e332a9b4a02 (cherry picked from commit 0817eaa)
This was referenced Aug 10, 2023
This was referenced Jan 8, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In an effort to fix #37753, this PR reverts the changes introduced by cd6a913 and 1d51032 so border-radius width calculations work as expected
Changelog:
[ANDROID] [FIXED] - Fix border-radius width calculations
Test Plan:
Test border colors along with border-radius through RNTester
