W3CPointerEvents: fix NPE due to null targetView #37785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46562263 |
Base commit: 6ebee63 |
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#37785 Changelog: [Android] [Fixed] - W3CPointerEvents: fix NPE due to null targetView For reasons not entirely understood, we sometimes end up with a null `targetView` in this code path during the dispatch of an `ACTION_CANCEL`. This results in an NPE during the call to `getChildOffsetRelativeToRoot`. This change adds a null check before the call to avoid the crash. Reviewed By: cortinico Differential Revision: D46562263 fbshipit-source-id: 64e265a0140a898908b5959c27bf38003f29ce0f
|
This pull request was exported from Phabricator. Differential Revision: D46562263 |
Summary: Pull Request resolved: facebook#37785 Changelog: [Android] [Fixed] - W3CPointerEvents: fix NPE due to null targetView For reasons not entirely understood, we sometimes end up with a null `targetView` in this code path during the dispatch of an `ACTION_CANCEL`. This results in an NPE during the call to `getChildOffsetRelativeToRoot`. This change adds a null check before the call to avoid the crash. Reviewed By: cortinico Differential Revision: D46562263 fbshipit-source-id: a6e8276cfb7213e5a0f64b78bd0ac8b6220e5f0b
|
This pull request was exported from Phabricator. Differential Revision: D46562263 |
|
This pull request has been merged in 96fd107. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android] [Fixed] - W3CPointerEvents: fix NPE due to null targetView
For reasons not entirely understood, we sometimes end up with a null
targetViewin this code path during the dispatch of anACTION_CANCEL. This results in an NPE during the call togetChildOffsetRelativeToRoot. This change adds a null check before the call to avoid the crash.Differential Revision: D46562263