Extract logic to CellMetricsAggregator #37777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46427052 |
Base commit: 108309e |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37777 This extracts the state and logic VirtualizedList uses to query information related to cell metrics. We will need to modify this (and other places) when fixing up RTL support for horizontal FlatList. Changelog: [Internal] Reviewed By: javache Differential Revision: D46427052 fbshipit-source-id: e4e0bbc49a3792091e7867a982b5bd4ac5071298
NickGerleman
force-pushed
the
export-D46427052
branch
from
dc0da6f to
07bb87d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46427052 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37777 This extracts the state and logic VirtualizedList uses to query information related to cell metrics. We will need to modify this (and other places) when fixing up RTL support for horizontal FlatList. Changelog: [Internal] Reviewed By: javache Differential Revision: D46427052 fbshipit-source-id: 71f09ca5cf17837c7e89c1f722a430aa0a5a0b9d
NickGerleman
force-pushed
the
export-D46427052
branch
from
07bb87d to
9ed299d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46427052 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 8, 2023
Summary: Pull Request resolved: facebook#37777 This extracts the state and logic VirtualizedList uses to query information related to cell metrics. We will need to modify this (and other places) when fixing up RTL support for horizontal FlatList. Changelog: [Internal] Reviewed By: javache Differential Revision: D46427052 fbshipit-source-id: c3a5c3da24cd02ad62a72e26e740ebf5e0473a85
NickGerleman
force-pushed
the
export-D46427052
branch
from
9ed299d to
3c5b528
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46427052 |
Summary: These functions describe how to get the metrics of a specific cell. "Frame" here seems non-descriptive and redundant to the "Metrics" part. Renaming this before a larger refactor. Changelog: [Internal] Differential Revision: D46427058 fbshipit-source-id: 84be31198d43be060f86f8866e07dbffde4a3455
Summary: Pull Request resolved: facebook#37777 This extracts the state and logic VirtualizedList uses to query information related to cell metrics. We will need to modify this (and other places) when fixing up RTL support for horizontal FlatList. Changelog: [Internal] Reviewed By: javache Differential Revision: D46427052 fbshipit-source-id: 6f4ca2324f920dd6bf2d31016efa29f948c39026
NickGerleman
force-pushed
the
export-D46427052
branch
from
3c5b528 to
0de6a15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46427052 |
|
This pull request has been merged in 8f7f0bf. |
|
@matinzd I believe this might find this one interesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This extracts the state and logic VirtualizedList uses to query information related to cell metrics. We will need to modify this (and other places) when fixing up RTL support for horizontal FlatList.
Changelog: [Internal]
Reviewed By: javache
Differential Revision: D46427052