Create a Debug manifest inside React Native Android #37771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46556884 |
Summary: Pull Request resolved: facebook#37771 While working on debugging tools, I noticed that we ask in every template app to - Add a "com.facebook.react.devsupport.DevSettingsActivity" activity - Add the <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> This is error prone and can be cleanup as we now distribute React Native that is variant aware (debug/release). So I'm creating a manifest inside `src/debug` that contains those directive so we don't need to ask users to add them (I'm removing them from the template). Changelog: [Internal] [Changed] - Create a Debug manifest inside React Native Android Reviewed By: cipolleschi Differential Revision: D46556884 fbshipit-source-id: 366badbc8cd8485ca0262ef89f57909b0eabf048
cortinico
force-pushed
the
export-D46556884
branch
from
e4f963a to
b12ca86
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46556884 |
Base commit: 3221f37 |
|
This pull request has been merged in f3c8636. |
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#37771 While working on debugging tools, I noticed that we ask in every template app to - Add a "com.facebook.react.devsupport.DevSettingsActivity" activity - Add the <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> This is error prone and can be cleanup as we now distribute React Native that is variant aware (debug/release). So I'm creating a manifest inside `src/debug` that contains those directive so we don't need to ask users to add them (I'm removing them from the template). Changelog: [Internal] [Changed] - Create a Debug manifest inside React Native Android Reviewed By: cipolleschi Differential Revision: D46556884 fbshipit-source-id: 10034a6b245bf419dfa663bc998c4d1ad5d24a90 Original: facebook/react-native@f3c8636
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#37771 While working on debugging tools, I noticed that we ask in every template app to - Add a "com.facebook.react.devsupport.DevSettingsActivity" activity - Add the <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> This is error prone and can be cleanup as we now distribute React Native that is variant aware (debug/release). So I'm creating a manifest inside `src/debug` that contains those directive so we don't need to ask users to add them (I'm removing them from the template). Changelog: [Internal] [Changed] - Create a Debug manifest inside React Native Android Reviewed By: cipolleschi Differential Revision: D46556884 fbshipit-source-id: 10034a6b245bf419dfa663bc998c4d1ad5d24a90 Original-Commit: facebook/react-native@f3c8636
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#37771 While working on debugging tools, I noticed that we ask in every template app to - Add a "com.facebook.react.devsupport.DevSettingsActivity" activity - Add the <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> This is error prone and can be cleanup as we now distribute React Native that is variant aware (debug/release). So I'm creating a manifest inside `src/debug` that contains those directive so we don't need to ask users to add them (I'm removing them from the template). Changelog: [Internal] [Changed] - Create a Debug manifest inside React Native Android Reviewed By: cipolleschi Differential Revision: D46556884 fbshipit-source-id: 10034a6b245bf419dfa663bc998c4d1ad5d24a90 Original-Commit: facebook/react-native@f3c8636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on debugging tools, I noticed that we ask in every template app to
This is error prone and can be cleanup as we now distribute React Native that is variant aware (debug/release).
So I'm creating a manifest inside
src/debugthat contains those directive so we don't need to ask usersto add them (I'm removing them from the template).
Changelog:
[Internal] [Changed] - Create a Debug manifest inside React Native Android
Reviewed By: cipolleschi
Differential Revision: D46556884