W3CPointerEvents: properly update hit path during native gestures #37638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
Base commit: 3f0caed |
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
May 31, 2023
…cebook#37638) Summary: Pull Request resolved: facebook#37638 Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures Per [the W3C spec](https://www.w3.org/TR/pointerevents/#the-pointercancel-event), we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence). Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted). Reviewed By: javache Differential Revision: D46226021 fbshipit-source-id: 66d53aa885a4c3029aeb6d74c8556863dac9b635
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
Jun 1, 2023
…cebook#37638) Summary: Pull Request resolved: facebook#37638 Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures Per [the W3C spec](https://www.w3.org/TR/pointerevents/#the-pointercancel-event), we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence). Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted). Reviewed By: javache Differential Revision: D46226021 fbshipit-source-id: c583771b99efd1480b51e44bb0bf0a9f3a97779b
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
Jun 1, 2023
…cebook#37638) Summary: Pull Request resolved: facebook#37638 Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures Per [the W3C spec](https://www.w3.org/TR/pointerevents/#the-pointercancel-event), we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence). Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted). Reviewed By: javache Differential Revision: D46226021 fbshipit-source-id: b5dbd2982f72c877a6f0cdbb91c8549bdc739050
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
Jun 6, 2023
…cebook#37638) Summary: Pull Request resolved: facebook#37638 Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures Per [the W3C spec](https://www.w3.org/TR/pointerevents/#the-pointercancel-event), we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence). Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted). Reviewed By: javache Differential Revision: D46226021 fbshipit-source-id: 585ebb806d2e1417f8f6fb462b85b3ddf4ae2b41
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
Jun 6, 2023
…cebook#37638) Summary: Pull Request resolved: facebook#37638 Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures Per [the W3C spec](https://www.w3.org/TR/pointerevents/#the-pointercancel-event), we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence). Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted). Reviewed By: javache Differential Revision: D46226021 fbshipit-source-id: fb417bdab14167fe6f3020ff269aa80f6a3fffb9
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
…cebook#37638) Summary: Pull Request resolved: facebook#37638 Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures Per [the W3C spec](https://www.w3.org/TR/pointerevents/#the-pointercancel-event), we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence). Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted). Reviewed By: javache Differential Revision: D46226021 fbshipit-source-id: 1267b6e122dfd4aafd47028d87c9be7e95d7a001
|
This pull request was exported from Phabricator. Differential Revision: D46226021 |
|
This pull request has been merged in 396cdac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android] [Fixed] - W3CPointerEvents: properly update hit path during native gestures
Per the W3C spec, we need to fire pointerout and pointerleave after firing a pointercancel. However, in cases where the pointer doesn't physically leave the target after a cancel (e.g. scrolling by clicking and dragging), we would never re-fire a pointerenter event once the native gesture was completed. This change fixes the bug by clearing out the last hit path (and other relevant state) for the pointer when we start handling a native gesture. Then we'll re-fire a pointerenter as expected upon the next motion event (due to the logic in handleHitStateDivergence).
Note: this bug only affected hovering pointers (e.g. mouse) because for non-hovering pointers the native gesture won't end unless the pointer is physically removed (i.e. finger is lifted).
Reviewed By: javache
Differential Revision: D46226021