Call invalidate on ViewManager on context destroy #37481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45945678 |
Base commit: f10dd3f |
Summary: Pull Request resolved: facebook#37481 ViewManagers inherit from BaseJavaModule so we should honour the same lifecycle for them as we do for native modules, which is to call `invalidate` / `onCatalystInstanceDestroy` when the ReactContext is destroyed. This allows the ViewManager to do any cleanup which cannot happen at the View level. Changelog: [Android][Fixed] ViewManagers now receive an invalidate callback Reviewed By: cortinico Differential Revision: D45945678 fbshipit-source-id: 158832c5fc61697d090fe306088314ab20f26c81
|
This pull request was exported from Phabricator. Differential Revision: D45945678 |
|
This pull request has been merged in c5e7cd4. |
fortmarek
pushed a commit
that referenced
this pull request
Dec 19, 2023
Summary: Pull Request resolved: #37481 ViewManagers inherit from BaseJavaModule so we should honour the same lifecycle for them as we do for native modules, which is to call `invalidate` / `onCatalystInstanceDestroy` when the ReactContext is destroyed. This allows the ViewManager to do any cleanup which cannot happen at the View level. Changelog: [Android][Fixed] ViewManagers now receive an invalidate callback Reviewed By: cortinico Differential Revision: D45945678 fbshipit-source-id: 27c26d951b50a734c42eb033a46e599ef939e29f
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ViewManagers inherit from BaseJavaModule so we should honour the same lifecycle for them as we do for native modules, which is to call
invalidate/onCatalystInstanceDestroywhen the ReactContext is destroyed. This allows the ViewManager to do any cleanup which cannot happen at the View level.Changelog: [Android][Fixed] ViewManagers now receive an invalidate callback
Differential Revision: D45945678