Remove duplicated code that resulted after a merge conflict. #37477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45979013 |
Base commit: 6d24ee1 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 21, 2023
…k#37477) Summary: Pull Request resolved: facebook#37477 When creating a stack of several codegen fixes, a conflit generated some duplicated code we moved to the parsers from the utils. This change removes that duplicated cone. ## Changelog: [Genearal][Fixed] - Remove duplicated code. Reviewed By: cortinico Differential Revision: D45979013 fbshipit-source-id: 4195bab3ab7e27a56cbec92cdb032b5a3d7b1b73
cipolleschi
force-pushed
the
export-D45979013
branch
from
c221d1c to
cf1954e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45979013 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45979013 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 22, 2023
…k#37477) Summary: Pull Request resolved: facebook#37477 When creating a stack of several codegen fixes, a conflit generated some duplicated code we moved to the parsers from the utils. This change removes that duplicated cone. ## Changelog: [Genearal][Fixed] - Remove duplicated code. Reviewed By: cortinico Differential Revision: D45979013 fbshipit-source-id: 7a9dde2c9c0dfeb24f45d6a5f96c384ad1423108
cipolleschi
force-pushed
the
export-D45979013
branch
from
cf1954e to
aa80a45
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 22, 2023
…k#37477) Summary: Pull Request resolved: facebook#37477 When creating a stack of several codegen fixes, a conflit generated some duplicated code we moved to the parsers from the utils. This change removes that duplicated cone. ## Changelog: [Genearal][Fixed] - Remove duplicated code. Reviewed By: cortinico Differential Revision: D45979013 fbshipit-source-id: c23dbb491c5ed2be5e29ae2719851772cc1f75c8
cipolleschi
force-pushed
the
export-D45979013
branch
from
aa80a45 to
aeef68e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45979013 |
Summary: We recently landed a change with a typo in the interface declaration. We just fixed the typo ## CHANGELOG [General][Fixed] - Fixed a typo in the interface declaration Differential Revision: D45978419 fbshipit-source-id: da6ab32273a01c8c42750f6cc736a8c5bd11510f
…k#37477) Summary: Pull Request resolved: facebook#37477 When creating a stack of several codegen fixes, a conflit generated some duplicated code we moved to the parsers from the utils. This change removes that duplicated cone. ## Changelog: [Genearal][Fixed] - Remove duplicated code. Reviewed By: cortinico Differential Revision: D45979013 fbshipit-source-id: 4f75089af1e2e9cf4f2ee806953ce407aa0408dd
cipolleschi
force-pushed
the
export-D45979013
branch
from
aeef68e to
905b6a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45979013 |
|
This pull request has been merged in 8dcaa4c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When creating a stack of several codegen fixes, a conflit generated some duplicated code we moved to the parsers from the utils.
This change removes that duplicated cone.
Changelog:
[Genearal][Fixed] - Remove duplicated code.
Differential Revision: D45979013