Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra semis (#21) #37360

Closed
wants to merge 1 commit into from
Closed

Conversation

Polyomino
Copy link

Summary: Pull Request resolved: facebook/igl#21

Reviewed By: nlutsenko

Differential Revision: D45722118

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 10, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 10, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko

Differential Revision: D45722118

fbshipit-source-id: 164159835fd0d55df5ec7cc3a5591b6d44338b56
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 10, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko

Differential Revision: D45722118

fbshipit-source-id: e9378765ac32b274c6834fa5b953a10cbdbaece1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 10, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko

Differential Revision: D45722118

fbshipit-source-id: b1defc3acc96e073466aa3b9c8d77d43404a8855
Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 10, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko

Differential Revision: D45722118

fbshipit-source-id: 0879fa9e7e60f48e9485de4e943e8f45ab230233
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 10, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko

Differential Revision: D45722118

fbshipit-source-id: 5e0e8f749cad2fe5f598507b40392df18c0ae654
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

@analysis-bot
Copy link

analysis-bot commented May 10, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,724,168 -2
android hermes armeabi-v7a 8,035,176 -3
android hermes x86 9,212,808 -2
android hermes x86_64 9,065,950 +2
android jsc arm64-v8a 9,288,912 +0
android jsc armeabi-v7a 8,477,343 -2
android jsc x86 9,348,927 +0
android jsc x86_64 9,605,683 +0

Base commit: 6392b53
Branch: main

Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 3f0466113832f82bd41ac56b2cb9c879a7e8293a
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 32de641e7f5bd493815ddba75ab0ba0ffba65cbe
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 3296901e8cf0eb9fb48ca517ecc9a4a7030c37aa
Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: bb168e173e205805fd2cf72c1961c51487ed87a9
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: b3c4aefb875731c9da3de3a2c01db8fd4079b0c8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: dfad9968df7d74ab2ee06292509f7ba0e9aa1f32
Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 11, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 708f8ff6f08ee57996399fd2918b21975a17cddd
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 1df325940703438509c4f8614279aec45a3a1374
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 11, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 178c85579f09bf20509c8501ab6d9a87a57402ba
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 3ff34fb00d2a5887a0548aea7ebd7640004c3d9e
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 52e54d25485f7924695b57489d7198704d192a3c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: c2e62e94de77e0b78a12f6599a9fb5978b5a6ed9
Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 97098cc12e34200c1255c4cba3059a1110696829
Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: be1e83e280c9bc39901d9028f37bdf730bed9268
Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 19d031c7fbad5c1cc327fe6a6cbee9da1ff2fa5f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 11b8f22adab2e49e5b0896e5e9ff468297c71bbf
Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 24df07623b17a37f07aaeacbcec3c32b8f308ad0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/react-native that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: e250982be375148f6702ea634e4737b2fd21cda8
Summary:
X-link: facebook/yoga#1289

Pull Request resolved: facebook#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: 52e8884b1a6b8285bfcb5b418dce93e1e270d144
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45722118

Polyomino pushed a commit to Polyomino/yoga that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: facebook#1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: da17ae3b7f595e0b18d5f7ff05fd0a73359da0d6
Polyomino pushed a commit to Polyomino/litho that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: facebook#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: d5802cf0438ce943abeec08c114cad3cbafa1792
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 12, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e985470.

facebook-github-bot pushed a commit to facebook/litho that referenced this pull request May 12, 2023
Summary:
X-link: facebook/yoga#1289

X-link: facebook/react-native#37360

Pull Request resolved: #947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: a749ca9e979d4447e65d075493c251169f81c289
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request May 12, 2023
Summary:
Pull Request resolved: #1289

X-link: facebook/react-native#37360

X-link: facebook/litho#947

X-link: facebook/igl#21

Reviewed By: nlutsenko, NickGerleman

Differential Revision: D45722118

fbshipit-source-id: a749ca9e979d4447e65d075493c251169f81c289
@Polyomino Polyomino changed the title remove extra semis from arfx/atlas/modules and deps (#21) remove extra semis (#21) May 12, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by cd223d6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants