Add React-FabricImage pod to solve Circulare dependency between Fabric image component and ImageManager #37276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
Base commit: e540d05 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 5, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: D45517278 fbshipit-source-id: 7390684fef3dd1470c236c51078e2e01425eb8ec
cipolleschi
force-pushed
the
export-D45517278
branch
from
8a050be to
2b70add
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: e2d93456b195db6bbcc95647f21f9fe3ab8b865b
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 12fa69975282abd73bf5259033cd247e41359f0a
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: b27560d1c10519ea8a3a2cd0d20641752ab7f148
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 511397fb476f5da18ae223f5639122d2e982cc1e
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 99c4c64bd041763195824280e66fbbacf56a1fbe
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 3fbaee6fa9a00b78f0d0ae8400862293f353cdf6
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: D45517278 fbshipit-source-id: 38d5e8c79de5f19baa5b7551ee428702b5df8f43
cipolleschi
force-pushed
the
export-D45517278
branch
from
2b70add to
f22797c
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 25047ad883d2286b1d1e2303558f1792d57a414a
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: c9ecc48e9d87f057f1e59a902aad0a23d3d20a4a
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 23abaaab744d1df90187837f921412248211962e
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: b853a1dca953cb591c90fb04e0eea56933a45641
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: c17787711ef6f4f9b8d64e02b2453858abcf7f49
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Reviewed By: NickGerleman Differential Revision: D45517278 fbshipit-source-id: b6b7f33e8ec130611f5aecf764246c0f6344b452
cipolleschi
force-pushed
the
export-D45517278
branch
from
f22797c to
b8052a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: c6800c05d7378632c173ad89ef0492abecf980c8
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: cc8950efb6eaaea51d38bb90e259aca86dfec60f
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 7331e88c005ea871fd176654498ea8d2e709648c
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Reviewed By: NickGerleman Differential Revision: D45517278 fbshipit-source-id: 5eda8630715351798671978e67019a71876ded37
cipolleschi
force-pushed
the
export-D45517278
branch
from
b8052a9 to
720998f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45517278 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 89c991bed7c170c6bb2f7f6e8b19ec64847f5454
|
This pull request has been merged in 44af6ca. |
|
@cipolleschi getting: I believe this is the culprit. Currently debugging why. |
|
Figured it out, we had: Changing it to the following seems to have fixed this issue: Leaving it here as it may help someone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager.
Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking.
Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec.
This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths.
Changelog
[iOS][Breaking] - Add React-FabricImage pod.
Differential Revision: D45517278