Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN: Make hermes-inspector-msggen tests visible for jest matcher #37131

Closed
wants to merge 1 commit into from
Closed

RN: Make hermes-inspector-msggen tests visible for jest matcher #37131

wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Apr 27, 2023

Summary:
Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

  • Renamed tests to kebab-case
  • Some of them were failing, now updated

Differential Revision: D45368748

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

hoxyq added a commit to hoxyq/react-native that referenced this pull request Apr 27, 2023
@hoxyq @facebook-github-bot
RN: Make hermes-inspector-msggen tests visible for jest matcher (fa…
0918cd5 
…cebook#37131)

Summary:
Pull Request resolved: facebook#37131

Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

- Renamed tests to kebab-case
- Some of them were failing, now updated

Differential Revision: D45368748

fbshipit-source-id: c115b5615a03e4c91d0217cf76502bc154a29f81
@hoxyq hoxyq force-pushed the export-D45368748 branch from 64e46c6 to 0918cd5 Compare April 27, 2023 20:19
@analysis-bot
Copy link

analysis-bot commented Apr 27, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,721,318 +0
android hermes armeabi-v7a 8,032,039 +0
android hermes x86 9,208,866 +1
android hermes x86_64 9,062,316 +1
android jsc arm64-v8a 9,285,676 -1
android jsc armeabi-v7a 8,473,837 +0
android jsc x86 9,344,618 +1
android jsc x86_64 9,601,678 +2

Base commit: 8132500
Branch: main

@Pranav-yadav
Copy link
Contributor

Pranav-yadav commented Apr 27, 2023 •
edited
Loading

@hoxyq does this mean all (js) test files using other than kebab-case naming styles are/will be also ignored by jest?

@Pranav-yadav Pranav-yadav added the Tests This PR adds or edits a test case. label Apr 27, 2023
@hoxyq
Copy link
Contributor Author

hoxyq commented Apr 28, 2023 •
edited
Loading

@hoxyq does this mean all (js) test files using other than kebab-case naming styles are/will be also ignored by jest?

Yes, every test suite with a file path, which doesn't match '/__tests__/.*-test(\\.fb)?\\.js$' will be ignored

@Pranav-yadav
Copy link
Contributor

@hoxyq does this mean all (js) test files using other than kebab-case naming styles are/will be also ignored by jest?

Yes, every test suite with a file path, which doesn't match '/__tests__/.*-test(\\.fb)?\\.js$' will be ignored

Sure. Tried grep to see if more tests affected by this, seems all other tests are using kebab-case 👍

@hoxyq hoxyq force-pushed the export-D45368748 branch from 0918cd5 to 3056368 Compare May 2, 2023 09:36
hoxyq added a commit to hoxyq/react-native that referenced this pull request May 2, 2023
@hoxyq @facebook-github-bot
RN: Make hermes-inspector-msggen tests visible for jest matcher (fa…
3056368 
…cebook#37131)

Summary:
Pull Request resolved: facebook#37131

Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

- Renamed tests to kebab-case
- Some of them were failing, now updated

Differential Revision: D45368748

fbshipit-source-id: b37ddd6c614badacf4be4d32e8dfe836a880fb33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

hoxyq added a commit to hoxyq/react-native that referenced this pull request May 2, 2023
@hoxyq @facebook-github-bot
RN: Make hermes-inspector-msggen tests visible for jest matcher (fa…
495d4db 
…cebook#37131)

Summary:
Pull Request resolved: facebook#37131

Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

- Renamed tests to kebab-case
- Some of them were failing, now updated

Differential Revision: D45368748

fbshipit-source-id: b01c57e8b5b35d80c1c6d9e42824794542ce57c2
@hoxyq hoxyq force-pushed the export-D45368748 branch from 3056368 to 495d4db Compare May 2, 2023 09:43
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

@hoxyq hoxyq force-pushed the export-D45368748 branch from 495d4db to 00f6fe0 Compare May 9, 2023 09:23
hoxyq added a commit to hoxyq/react-native that referenced this pull request May 9, 2023
@hoxyq @facebook-github-bot
RN: Make hermes-inspector-msggen tests visible for jest matcher (fa…
00f6fe0 
…cebook#37131)

Summary:
Pull Request resolved: facebook#37131

Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

- Renamed tests to kebab-case
- Some of them were failing, now updated

Reviewed By: motiz88

Differential Revision: D45368748

fbshipit-source-id: 919771391ab4121bda12e8bb8aaa6f629577f67c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

hoxyq added a commit to hoxyq/react-native that referenced this pull request May 9, 2023
@hoxyq @facebook-github-bot
RN: Make hermes-inspector-msggen tests visible for jest matcher (fa…
9e60751 
…cebook#37131)

Summary:
Pull Request resolved: facebook#37131

Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

- Renamed tests to kebab-case
- Some of them were failing, now updated

Reviewed By: motiz88

Differential Revision: D45368748

fbshipit-source-id: cc1fe129c84c31f16c7ffada5424996009a84d0a
@hoxyq hoxyq force-pushed the export-D45368748 branch from 00f6fe0 to 9e60751 Compare May 9, 2023 09:29
@hoxyq @facebook-github-bot
RN: Make hermes-inspector-msggen tests visible for jest matcher (fa…
c31a045 
…cebook#37131)

Summary:
Pull Request resolved: facebook#37131

Changelog: [Internal]

Looks like all this time jest was not running these tests, because their file names are not matching the
https://www.internalfb.com/code/fbsource/[1e8a1b307ffd]/xplat/js/react-native-github/jest.config.js?lines=30

- Renamed tests to kebab-case
- Some of them were failing, now updated

Reviewed By: motiz88

Differential Revision: D45368748

fbshipit-source-id: ff098a9ba6f70658300aa787c9b2dc9b02fab256
@hoxyq hoxyq force-pushed the export-D45368748 branch from 9e60751 to c31a045 Compare May 9, 2023 09:38
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45368748

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e540d05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Tests This PR adds or edits a test case.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoxyq @facebook-github-bot @analysis-bot @Pranav-yadav