-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ReactTextView setPadding applying logic error #36999
Conversation
Fix the logic error when setPadding int ReactTextView.
Hi @jcdhlzq! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: a320dce |
Summary: Fix the logic error when setPadding int ReactTextView. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #36999 Reviewed By: NickGerleman Differential Revision: D45773288 Pulled By: javache fbshipit-source-id: ed4681aeab58ed4c3d2e04edb2d096b50932c088
This pull request was successfully merged by @jcdhlzq in d8ced6f. When will my fix make it into a release? | Upcoming Releases |
Fix the logic error when setPadding int ReactTextView.
Summary:
Changelog:
Test Plan: