Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReactTextView setPadding applying logic error #36999

Closed
wants to merge 2 commits into from

Conversation

jcdhlzq
Copy link
Contributor

@jcdhlzq jcdhlzq commented Apr 20, 2023

Fix the logic error when setPadding int ReactTextView.

Summary:

Changelog:

Test Plan:

Fix the logic error when setPadding int ReactTextView.
@facebook-github-bot
Copy link
Contributor

Hi @jcdhlzq!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions
Copy link

github-actions bot commented Apr 20, 2023

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against 9f36da8

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2023
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jcdhlzq jcdhlzq closed this May 12, 2023
@jcdhlzq jcdhlzq reopened this May 12, 2023
@jcdhlzq jcdhlzq closed this May 12, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,724,249 +108
android hermes armeabi-v7a 8,035,221 +106
android hermes x86 9,212,835 +109
android hermes x86_64 9,066,053 +111
android jsc arm64-v8a 9,288,695 -188
android jsc armeabi-v7a 8,477,091 -186
android jsc x86 9,348,670 -192
android jsc x86_64 9,605,492 -190

Base commit: a320dce
Branch: main

facebook-github-bot pushed a commit that referenced this pull request May 15, 2023
Summary:
Fix the logic error when setPadding int ReactTextView.

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Pull Request resolved: #36999

Reviewed By: NickGerleman

Differential Revision: D45773288

Pulled By: javache

fbshipit-source-id: ed4681aeab58ed4c3d2e04edb2d096b50932c088
@github-actions
Copy link

This pull request was successfully merged by @jcdhlzq in d8ced6f.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants