Use stable sort for performance entries #36998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45142500 |
|
Differential Revision: https://internalfb.com/D45141978 fbshipit-source-id: 0100e1f3020a893550f3f4b67f36fa11873ac5f0
Summary: Pull Request resolved: facebook#36998 For performance entries that have the same start/end time it makes more sense to report them back to `PerformanceObserver` in the same order they were logged. This kind of determinism is arguably better both in terms of API, and from the point of view of testing. ## Chagelog: [Internal] - Reviewed By: javache Differential Revision: D45142500 fbshipit-source-id: 7c5897ef3e9f9728c25016b7e6aa99bd23ac9bff
rshest
force-pushed
the
export-D45142500
branch
from
8826dde to
6f22934
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45142500 |
|
This pull request has been merged in 8e046cb. |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 21, 2023
Summary: Changelog: [Internal] Re-submitting facebook#36998, which was reverted earlier due to the internal compatibility check issues. Differential Revision: D45177697 fbshipit-source-id: e5c42d4db482a2d444d7c609aba95bc7a871823f
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 21, 2023
Summary: Changelog: [Internal] Re-submitting facebook#36998, which was reverted earlier due to the internal compatibility check issues. Differential Revision: D45177862 fbshipit-source-id: ce9930b51e45ef7abcf93d578b3f337b256a23eb
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 21, 2023
Summary: Changelog: [Internal] Re-submitting facebook#36998, which was reverted earlier due to the internal compatibility check issues. Differential Revision: D45177697 fbshipit-source-id: 39ffc59bdfe7821c66c8c64e1215b1aca19df8d9
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 21, 2023
Summary: Pull Request resolved: facebook#37017 Changelog: [Internal] Re-submitting facebook#36998, which was reverted earlier due to the internal compatibility check issues. Reviewed By: cipolleschi Differential Revision: D45177862 fbshipit-source-id: e0baa2533f6428dc810102def437176606fcb82e
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36998 For performance entries that have the same start/end time it makes more sense to report them back to `PerformanceObserver` in the same order they were logged. This kind of determinism is arguably better both in terms of API, and from the point of view of testing. Changelog: [Internal] Reviewed By: javache Differential Revision: D45142500 fbshipit-source-id: 77ff0093bead45dc2f15efc4b903dc181927565a
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37017 Changelog: [Internal] Re-submitting facebook#36998, which was reverted earlier due to the internal compatibility check issues. Reviewed By: cipolleschi Differential Revision: D45177862 fbshipit-source-id: f47ef496e3d7531b5e077310c72def80b024be6e
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36998 For performance entries that have the same start/end time it makes more sense to report them back to `PerformanceObserver` in the same order they were logged. This kind of determinism is arguably better both in terms of API, and from the point of view of testing. Changelog: [Internal] Reviewed By: javache Differential Revision: D45142500 fbshipit-source-id: 77ff0093bead45dc2f15efc4b903dc181927565a
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#37017 Changelog: [Internal] Re-submitting facebook#36998, which was reverted earlier due to the internal compatibility check issues. Reviewed By: cipolleschi Differential Revision: D45177862 fbshipit-source-id: f47ef496e3d7531b5e077310c72def80b024be6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For performance entries that have the same start/end time it makes more sense to report them back to
PerformanceObserverin the same order they were logged.This kind of determinism is arguably better both in terms of API, and from the point of view of testing.
Chagelog: [Internal]
Reviewed By: javache
Differential Revision: D45142500