Use C++17 namespace format #36983
Closed
Use C++17 namespace format #36983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
Base commit: 50553f4 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 8279d93356332d4053f0844c6b6bd6c3d770722e
christophpurrer
force-pushed
the
export-D45121589
branch
from
754317d to
4132607
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 8ffb4232f285f19119e67996f11013fb6112e377
christophpurrer
force-pushed
the
export-D45121589
branch
from
4132607 to
159ccab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 3106d579adc2c2da1b8acf719d4b07f130880946
christophpurrer
force-pushed
the
export-D45121589
branch
from
159ccab to
5710bfb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: fab5024502b7712558008ea52d503a6d7e417adf
christophpurrer
force-pushed
the
export-D45121589
branch
from
5710bfb to
5fdc0df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 5d8b1b8ad6a4012c569b677c6b43424739c6e365
christophpurrer
force-pushed
the
export-D45121589
branch
from
5fdc0df to
11c514e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 474adb4a45211b21c5765ef3a08566f898ee4644
christophpurrer
force-pushed
the
export-D45121589
branch
from
11c514e to
65df8e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 5a3cc665051c5707da6197f992e57f5384443f85
christophpurrer
force-pushed
the
export-D45121589
branch
from
65df8e4 to
4c179ee
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 0bd4fa97f61f53504992fff87f5efd6586587ccc
christophpurrer
force-pushed
the
export-D45121589
branch
from
4c179ee to
2088808
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 20, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 084f7bf1215b335fc7f4158b93e243c0955f62fd
christophpurrer
force-pushed
the
export-D45121589
branch
from
2088808 to
e5c4bf2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 4aad2b8257a439a19a1a23b27b89321eee21af4a
|
This pull request was exported from Phabricator. Differential Revision: D45121589 |
christophpurrer
force-pushed
the
export-D45121589
branch
from
e5c4bf2 to
f411c00
Compare
|
This pull request has been merged in 79c42e7. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 0be5a7bce75dc9f8cde7856684f730f4d6df9202
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36983 Changelog: [Internal] This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files Reviewed By: NickGerleman Differential Revision: D45121589 fbshipit-source-id: 0be5a7bce75dc9f8cde7856684f730f4d6df9202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This updates ReactCommon/react code to use C++17 namespace format which was already used partially in other files
Differential Revision: D45121589