Codemod $Shape to Partial in xplat, suppressing errors [4]
#36960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45076273 |
Base commit: 6f94cd2 |
…ook#36960) Summary: Pull Request resolved: facebook#36960 We're deprecating the unsafe `$Shape` and moving to the safe `Partial`: https://fb.workplace.com/groups/flowlang/posts/1251655088773485 I have previously codemodded all locations that do not cause errors. Now start on the remaining ones: codemod and suppress. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D45076273 fbshipit-source-id: 951db0f6d850c2c20a87c146370b27a565ae2248
|
This pull request was exported from Phabricator. Differential Revision: D45076273 |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Apr 18, 2023
Summary: X-link: facebook/react-native#36960 We're deprecating the unsafe `$Shape` and moving to the safe `Partial`: https://fb.workplace.com/groups/flowlang/posts/1251655088773485 I have previously codemodded all locations that do not cause errors. Now start on the remaining ones: codemod and suppress. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D45076273 fbshipit-source-id: 27ebf33370143e19751dbdcfcc1876cf3c586e14
|
This pull request has been merged in e2116d2. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…ook#36960) Summary: Pull Request resolved: facebook#36960 We're deprecating the unsafe `$Shape` and moving to the safe `Partial`: https://fb.workplace.com/groups/flowlang/posts/1251655088773485 I have previously codemodded all locations that do not cause errors. Now start on the remaining ones: codemod and suppress. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D45076273 fbshipit-source-id: 27ebf33370143e19751dbdcfcc1876cf3c586e14
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ook#36960) Summary: Pull Request resolved: facebook#36960 We're deprecating the unsafe `$Shape` and moving to the safe `Partial`: https://fb.workplace.com/groups/flowlang/posts/1251655088773485 I have previously codemodded all locations that do not cause errors. Now start on the remaining ones: codemod and suppress. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D45076273 fbshipit-source-id: 27ebf33370143e19751dbdcfcc1876cf3c586e14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're deprecating the unsafe
$Shapeand moving to the safePartial: https://fb.workplace.com/groups/flowlang/posts/1251655088773485I have previously codemodded all locations that do not cause errors. Now start on the remaining ones: codemod and suppress.
Changelog: [Internal]
Reviewed By: SamChou19815
Differential Revision: D45076273