-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @tsconfig/react-native to 3.0.0 #36957
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Apr 18, 2023
This pull request was exported from Phabricator. Differential Revision: D45085932 |
cortinico
approved these changes
Apr 18, 2023
Summary: Pull Request resolved: facebook#36957 Fixes facebook#36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: c80e528277bfe10f54a66e3a1ef2fb71a8ea6588
This pull request was exported from Phabricator. Differential Revision: D45085932 |
NickGerleman
force-pushed
the
export-D45085932
branch
from
April 18, 2023 15:18
0db42fc
to
b591b67
Compare
Base commit: 7495883 |
This pull request has been merged in 5c4649a. |
kelset
pushed a commit
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: #36957 Fixes #36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: 448f1103ef13f76fa95884f790a3cccd9ff75b2f # Conflicts: # packages/react-native/template/package.json
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36957 Fixes facebook#36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: 448f1103ef13f76fa95884f790a3cccd9ff75b2f
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36957 Fixes facebook#36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: 448f1103ef13f76fa95884f790a3cccd9ff75b2f
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#36957 Fixes facebook/react-native#36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: 448f1103ef13f76fa95884f790a3cccd9ff75b2f Original: facebook/react-native@5c4649a
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#36957 Fixes facebook/react-native#36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: 448f1103ef13f76fa95884f790a3cccd9ff75b2f Original-Commit: facebook/react-native@5c4649a
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#36957 Fixes facebook/react-native#36830 This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19. I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72. Changelog: [General][Changed] - Bump tsconfig/react-native to 3.0.0 Reviewed By: cortinico Differential Revision: D45085932 fbshipit-source-id: 448f1103ef13f76fa95884f790a3cccd9ff75b2f Original-Commit: facebook/react-native@5c4649a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #36830
This bumps the version of tsconfig/react-native to inform TypeScript of more libraries provided by Hermes/React Native. See tsconfig/bases@eee5f19.
I did the search off of current Hermes/RN main branch, but I think the new config should be valid as far back as 0.71. It doesn't make sense to change the new app template for an old version though, so instead I think we should include this new version in 0.72.
Changelog:
[General][Changed] - Bump tsconfig/react-native to 3.0.0
Differential Revision: D45085932