Delete sStateDescription from BaseViewManager #36904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44682968 |
|
Base commit: d50934a |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36904 In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 bypass-github-export-checks changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Reviewed By: genkikondo Differential Revision: D44682968 fbshipit-source-id: c1118789fabb6f18d647043b2e8aa3071fccecb9
mdvacca
force-pushed
the
export-D44682968
branch
from
0d7e2e7 to
f021dbf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44682968 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44682968 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36904 In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 bypass-github-export-checks changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Reviewed By: genkikondo Differential Revision: D44682968 fbshipit-source-id: 3ac10a2ba0482d666ee604c1f743acf474cb5397
mdvacca
force-pushed
the
export-D44682968
branch
from
f021dbf to
35a987a
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 19, 2023
Summary: Pull Request resolved: facebook#36904 In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 bypass-github-export-checks changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Reviewed By: genkikondo Differential Revision: D44682968 fbshipit-source-id: b4cae9b6f65087e885f9c0273190adb69bf65fea
mdvacca
force-pushed
the
export-D44682968
branch
from
35a987a to
f6be5ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44682968 |
Summary: Pull Request resolved: facebook#36904 In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 bypass-github-export-checks changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Reviewed By: genkikondo Differential Revision: D44682968 fbshipit-source-id: 45188556ec2761f1284194b4f6981d1b92db2c68
|
This pull request was exported from Phabricator. Differential Revision: D44682968 |
mdvacca
force-pushed
the
export-D44682968
branch
from
f6be5ea to
589a312
Compare
|
This pull request has been merged in 6babe4a. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36904 In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 bypass-github-export-checks changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Reviewed By: genkikondo Differential Revision: D44682968 fbshipit-source-id: 732c32429b2c0c107f7968ece5b2e1ed256eed90
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36904 In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891 bypass-github-export-checks changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere Reviewed By: genkikondo Differential Revision: D44682968 fbshipit-source-id: 732c32429b2c0c107f7968ece5b2e1ed256eed90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm deleting sStateDescription from BaseViewManager, which their usages were originally deleted in D17152891
changelog: [Android][Deleted] Delete sStateDescription from BaseViewManager, it's safe to delete because it shouldn't be used anywhere
Reviewed By: genkikondo
Differential Revision: D44682968